Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save generator after migration #400

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix: save generator after migration #400

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ea95b6
save generator migration to disk
cristianoventura Jan 9, 2025
bb0c570
Revert "save generator migration to disk"
cristianoventura Jan 10, 2025
21be229
fix order of schema migration
cristianoventura Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/schemas/generator/v0/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ export type GeneratorSchema = z.infer<typeof GeneratorFileDataSchema>
export function migrate(generator: GeneratorSchema): v1.GeneratorSchema {
return {
version: '1.0',
allowlist: generator.allowlist,
includeStaticAssets: generator.includeStaticAssets,
options: generator.options,
recordingPath: generator.recordingPath,
options: generator.options,
testData: generator.testData,
rules: generator.rules,
allowlist: generator.allowlist,
includeStaticAssets: generator.includeStaticAssets,
Comment on lines +25 to +29
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was actually related to the order of the fields in the migration, which caused the JSON.stringify comparison to return false. I made a ticket to address this behaviour #403

scriptName: generator.scriptName,
testData: generator.testData,
}
}
Loading