Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move recording selector position #413

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cristianoventura
Copy link
Collaborator

Description

This PR moves the Recording dropdown from the "Requests" tab in the Preview section to the top bar on the Generator page.

How to Test

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (npm run lint) and all checks pass.
  • I have run tests locally (npm test) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Screenshots (if appropriate):

image

Smaller window size:

image

Related PR(s)/Issue(s)

Resolves #317

@cristianoventura cristianoventura self-assigned this Jan 15, 2025
@cristianoventura cristianoventura requested a review from a team as a code owner January 15, 2025 20:29
</>
)}
<RecordingSelector />
<Flex align="center" justify="between" gap="2">
Copy link
Collaborator Author

@cristianoventura cristianoventura Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change here was wrapping the content in this Flex component to achieve responsiveness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move recording selector position in the generator
1 participant