Discovery improvements #1120
Merged
Discovery improvements #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
petewall
requested review from
a team,
skl,
nevermind89x,
jewbetcha and
sleepyfoodie
and removed request for
a team
skl
approved these changes
Jan 16, 2025
Co-authored-by: Stephen Lang <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
Signed-off-by: Pete Wall <[email protected]>
petewall
added a commit
that referenced
this pull request
Jan 22, 2025
* Use new alloy modules to enable the right change to get openshift working Signed-off-by: Pete Wall <[email protected]> * Further improvements to discovery and openshift Signed-off-by: Pete Wall <[email protected]> * Update charts/k8s-monitoring/charts/feature-cluster-metrics/README.md Co-authored-by: Stephen Lang <[email protected]> * Also fix values.yaml Signed-off-by: Pete Wall <[email protected]> * More readme updates Signed-off-by: Pete Wall <[email protected]> --------- Signed-off-by: Pete Wall <[email protected]> Co-authored-by: Stephen Lang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses a new version of alloy modules that improves discovery for kube-state-metrics, node-exporter, and windows-exporter. This make it more efficient on most clusters and it will also make it functional on openshift clusters.