de-duplicate targets from portNumber annotation #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where sidecar containers (i.e vault agent) get registered as targets due to inheriting the pod's annotations for autodiscovery and resulting in alloy scraping the pod multiple times. This fix does a similar check as the portName check above it, and removes these additional targets if the
portNumber
annotation is specified and the container does not have a corresponding port number exposed.