Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de-duplicate targets from portNumber annotation #988

Closed
wants to merge 1 commit into from

Conversation

j6nca
Copy link

@j6nca j6nca commented Dec 10, 2024

We ran into an issue where sidecar containers (i.e vault agent) get registered as targets due to inheriting the pod's annotations for autodiscovery and resulting in alloy scraping the pod multiple times. This fix does a similar check as the portName check above it, and removes these additional targets if the portNumber annotation is specified and the container does not have a corresponding port number exposed.

@j6nca j6nca requested a review from a team as a code owner December 10, 2024 22:20
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@petewall
Copy link
Collaborator

petewall commented Jan 6, 2025

Please try things again with the latest (2.0.0-rc.13). I fixed an issue with duplicate port scraping.
I actually don't want the portNumber annotation to check for exposed ports, because sometimes, the metrics port is not exposed, but we need to explicitly set it to something. Only checking for exposed ports prevents this option.

@petewall
Copy link
Collaborator

petewall commented Jan 7, 2025

I'm going to close this, as we can't take a solution that requires the port number to be exposed.
Try with the latest version and see if that helps!

@petewall petewall closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants