feat: decouple offset manager from shared Kafka configuration #19257
+68
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/offset-manager-use-kgo-2
branch
2 times, most recently
from
89756fb to
3c5f1eb
Compare
| return nil, fmt.Errorf("failed to create kafka client for offset manager: %w", err) | ||
| } | ||
|
|
||
| consumerGroup := kafkaCfg.GetConsumerGroup(instanceID) |
There was a problem hiding this comment.
This was moved out of offset_manager.go. It is relevant for partition ingesters but not for limits service.
grobinson-grafana
force-pushed
the
grobinson/offset-manager-use-kgo-2
branch
from
3c5f1eb to
470ae33
Compare
This commit decouples the offset manager from the shared Kafka configuration. This is important as I will soon start work on a Kafka V2 client with a new configuration struct that is more generic and less coupled to the needs of partition ingesters.
grobinson-grafana
force-pushed
the
grobinson/offset-manager-use-kgo-2
branch
from
470ae33 to
383a6f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commit decouples the offset manager from the shared Kafka configuration. This is important as I will soon start work on a Kafka V2 client with a new configuration struct that is more generic and less coupled to the needs of partition ingesters.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR