fix: query stats always logs zero value(#11264) #19296
Open
+11
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Populates the querier stats with data derived from the query range response stats. This change allows the frontend component to access and log stats information passed through the context, providing a more comprehensive view of query performance.
Which issue(s) this PR fixes:
Fixes #11264 , fix zero value in "query stats" logs.
Since
querier_stats.Stats
is set to context here but never updated before log,we'll always get zero values in logs.The code referenced in the issue #11264 is very clear, so I will not repeat it here.
Before fixing:
once
-frontend.query-stats-enabled
option is enabled, followed logs will be printed.query_wall_time_seconds
,fetched_series_count
,fetched_series_count
always report 0After this fixing:
query_wall_time_seconds
,fetched_series_count
,fetched_series_count
will be accurate values as result.stats.Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR