-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use private network interfaces as default for ring and frontend #4961
Conversation
Signed-off-by: Christian Haudum <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I consider this a better default, I think it is considered a breaking change. That said, WDYT of documenting this in the upgrading guide?
@@ -158,54 +155,3 @@ func searchToken(tokens []uint32, key uint32) int { | |||
} | |||
return i | |||
} | |||
|
|||
// GetFirstAddressOf returns the first IPv4 address of the supplied interface names, omitting any 169.254.x.x automatic private IPs if possible. | |||
func getFirstAddressOf(names []string, logger log.Logger) (string, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm here you're changing vendor code 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I wanted to open it as a draft PR. The corresponding upstream PR in dskit is grafana/dskit#100
It would also need to be used in Cortex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, my bad.
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
Closing this as no activities for long time. Feel free to send new PR if anyone want's to revive the work |
Proof of concept for using private network interfaces as default for ring configurations.
What this PR does / why we need it:
At the moment, the default network interfaces for the ring configurations are
eth0
anden0
, which works for probably everyone running Loki inside Docker.However, if you run the Loki binary directly (which is a valid first use-case for Loki), it is very likely that Loki won't start because the primary network interface has a different name.
Checklist
CHANGELOG.md
about the changes.