-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LabelQuerier.LabelValuesStream method #517
Draft
aknuds1
wants to merge
14
commits into
main
Choose a base branch
from
arve/stream-labelvalues
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
July 21, 2023 17:08
a34d3e5
to
d9df8ef
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
August 7, 2023 11:53
d9df8ef
to
b0f52cd
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
17 times, most recently
from
September 5, 2023 08:23
abe07c3
to
d4a20e9
Compare
aknuds1
changed the title
WIP: Add LabelQuerier.LabelValuesSet method
WIP: Add Sep 5, 2023
LabelQuerier.LabelValuesStream
method
aknuds1
changed the title
WIP: Add
WIP: Add LabelQuerier.LabelValuesStream method
Sep 5, 2023
LabelQuerier.LabelValuesStream
method
aknuds1
changed the title
WIP: Add LabelQuerier.LabelValuesStream method
Add LabelQuerier.LabelValuesStream method
Sep 5, 2023
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
September 6, 2023 14:05
d4a20e9
to
65f1939
Compare
aknuds1
changed the title
Add LabelQuerier.LabelValuesStream method
WIP: Add LabelQuerier.LabelValuesStream method
Sep 6, 2023
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
5 times, most recently
from
September 11, 2023 15:31
16292cf
to
287e4a3
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
8 times, most recently
from
January 25, 2024 10:53
4902190
to
f630927
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
February 7, 2024 06:29
f630927
to
3ba7bd4
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
3 times, most recently
from
February 27, 2024 07:52
74562a1
to
4a5d3ee
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
2 times, most recently
from
March 13, 2024 11:33
5043c92
to
2e1e45f
Compare
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
March 19, 2024 13:23
2e1e45f
to
297854e
Compare
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Co-authored-by: Oleg Zaytsev <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
…ingsForMatchers Signed-off-by: Arve Knudsen <[email protected]>
…ForMatchers Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/stream-labelvalues
branch
from
April 26, 2024 13:47
297854e
to
ea571ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add method
storage.LabelQuerier.LabelValuesStream
that returns an iterator over corresponding label values, instead of a slice.Preliminary benchmark statistics, for respectively block and head index readers:
benchstat-block.txt
benchstat-head.txt
Depends on #576
Note to self
When the time comes to upstream, first post a proposal issue, to allow for discussion, before making a PR.
TODO:
tsdb.IndexReader
: AddLabelValuesFor
/LabelValuesExcluding
methods #576