-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with upstream v3.0 #741
Conversation
doc: fix formatting
* tsdb.CircularExemplarStorage: Avoid racing --------- Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: shenpengfeng <[email protected]>
chore: fix function name in comment
* [REFACTOR] simplify appender commit Signed-off-by: Nicolas Takashi <[email protected]> Signed-off-by: Arthur Silva Sens <[email protected]> Co-authored-by: George Krajcsovits <[email protected]> Co-authored-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Jan Fajerski <[email protected]>
Signed-off-by: Oleg Zaytsev <[email protected]>
…s-delete-with-gomaxprocs-workers Revert "Process `MemPostings.Delete()` with `GOMAXPROCS` workers"
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Signed-off-by: Jan Fajerski <[email protected]>
Prepare release 3.0.0 rc.0
bugfix: Fix otlp translator for foreign characters
tracing: add tcp events to remote store span
log last series labelset when hitting OOO series labels
…b.com/envoyproxy/go-control-plane-0.13.0
…b.com/scaleway/scaleway-sdk-go-1.0.0-beta.30
…g.org/x/oauth2-0.23.0
…g.org/x/tools-0.24.0
…b.com/prometheus/common-0.59.0
…entation/examples/remote_storage/github.com/prometheus/client_golang-1.20.2
…b.com/prometheus/exporter-toolkit-0.12.0
…b.com/prometheus/common-0.59.1
…b.com/digitalocean/godo-1.122.0 Signed-off-by: Arve Knudsen <[email protected]>
…entelemetry-io-14eb93439b
…s-delete-with-gomaxprocs-workers
Signed-off-by: Arve Knudsen <[email protected]>
9624637
to
6314392
Compare
Signed-off-by: Bryan Boreham <[email protected]>
Also grafana/regexp sorts alternates alphabetically. Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I scanned all diffs between mimir-prometheus and upstream prometheus after this PR, and didn't spot any errors.
Also looked specifically at tsdb/head_append.go
and model/labels/regexp_test.go
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Only noteworthy thing to me beside the regex matching change that we know about is the fact that this PR renames holt_winters PromQL function.
We should create an alias for |
We don't really need to do that here in |
@colega how can we do it in Mimir? |
ea3b08c
to
35ab16f
Compare
You can do it in Mimir through: func init() {
parser.Functions["holt_winters"] = parser.Functions["double_exponential_smoothing"]
promql.FunctionCalls["holt_winters"] = promql.FunctionCalls["double_exponential_smoothing"]
} |
@colega hm yeah, maybe it is that simple. I'll check. |
Sync with Prometheus upstream main branch (e2e01c1). My method was to list all the commits added to upstream's main branch after the last merge, and merge every single one of them, resolving conflicts per commit as necessary.
There were difficult merge conflicts in the following files/commits, and I could use help making sure they're done correctly in retrospect:
model/labels/regexp_test.go:
Included commits:
CreatedTimestamp
function (#14965)CreatedTimestamps
(#15097)MemPostings.Add
andMemPostings.Get
data race (#15141)p.isCreatedSeries()
(#15150)