Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync with upstream v3.0 #741

Merged
merged 1,006 commits into from
Nov 6, 2024
Merged

Sync with upstream v3.0 #741

merged 1,006 commits into from
Nov 6, 2024

Conversation

aknuds1
Copy link
Contributor

@aknuds1 aknuds1 commented Nov 5, 2024

Sync with Prometheus upstream main branch (e2e01c1). My method was to list all the commits added to upstream's main branch after the last merge, and merge every single one of them, resolving conflicts per commit as necessary.

There were difficult merge conflicts in the following files/commits, and I could use help making sure they're done correctly in retrospect:

Included commits:

  • 458613b Merge pull request #14846 from prometheus/dependabot/go_modules/github.com/envoyproxy/go-control-plane-0.13.0
  • 1ed25d5 Merge pull request #14843 from prometheus/dependabot/go_modules/github.com/scaleway/scaleway-sdk-go-1.0.0-beta.30
  • d4e1900 Merge pull request #14845 from prometheus/dependabot/go_modules/golang.org/x/oauth2-0.23.0
  • 55ed6f3 Merge pull request #14840 from prometheus/dependabot/go_modules/golang.org/x/tools-0.24.0
  • 788d8c2 Merge pull request #14839 from prometheus/dependabot/go_modules/github.com/prometheus/common-0.59.0
  • 1a17918 Merge pull request #14786 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/client_golang-1.20.2
  • 404e577 Merge pull request #14734 from roidelapluie/scrape_failure_logger
  • 59402f8 Merge pull request #14841 from prometheus/dependabot/go_modules/github.com/prometheus/exporter-toolkit-0.12.0
  • 8805301 Merge pull request #14851 from prometheus/dependabot/go_modules/github.com/prometheus/common-0.59.1
  • 5a1f4a7 Merge pull request #14842 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.122.0
  • a7a9dba Merge pull request #14837 from prometheus/dependabot/go_modules/go-opentelemetry-io-14eb93439b
  • 51e8b6f Merge pull request #14832 from prometheus/dependabot/go_modules/golang.org/x/text-0.18.0
  • f44304a Merge pull request #14804 from prometheus/dependabot/go_modules/github.com/linode/linodego-1.40.0
  • 828f340 Merge pull request #14791 from prometheus/dependabot/go_modules/github.com/miekg/dns-1.1.62
  • edc83ed Update storage.md with the latest around Remote Write 2.0 (#14848)
  • cb671ef Merge pull request #14788 from prometheus/dependabot/go_modules/k8s-io-a0fc09b0c0
  • 9f57f14 Merge pull request #14803 from prometheus/dependabot/go_modules/github.com/docker/docker-27.2.0incompatible
  • db5e48d promql.Engine.Close: No-op if nil (#14861)
  • 4fc562f OTLP: Support context cancellation/timeout during translation (#14612)
  • 09c1e0b Limit memory usage Go tests with race detector (#14862)
  • d289900 Merge pull request #14872 from prometheus/mantine-ui
  • ab5994d Merge pull request #14874 from krajorama/fix-panic-in-ooo-query2
  • 16e5e99 Merge pull request #14767 from bboreham/fix-encoding-comment
  • 6c79689 Merge pull request #14875 from prometheus/move-am-sd-menu-entry
  • 43cf9ad Merge pull request #14852 from roidelapluie/testqvalue
  • 1b281f0 Bump @types/node from 22.5.2 to 22.5.4 in /web/ui (#14873)
  • be0c0bd Fix error flood by downgrading OTel dependencies (#14884)
  • a634618 Merge pull request #14881 from rfratto/remove-rfratto-maintainer
  • 7741134 Merge pull request #14888 from roidelapluie/fix-discovered-alertmanagers
  • bde5092 Merge pull request #14882 from prometheus/new-ui-help-button
  • 3ce285e Merge pull request #14891 from roidelapluie/fix-lookback-delta
  • 482f1f6 Merge pull request #14880 from prometheus/njpm/fix-utf8-config
  • 8114f9a Merge pull request #14821 from charleskorn/nh-negative-multiplication-division
  • 8d3da31 Merge pull request #14885 from prometheus/superq/update_promci_2
  • 1bd10ac Merge pull request #14893 from roidelapluie/bottomkui
  • ad652de Merge pull request #14895 from prometheus/fix-limit-ratio-explain
  • 4e17166 Merge pull request #14896 from jan--f/release-3.0-beta.0
  • 54772a2 Bump actions/upload-artifact from 4.3.4 to 4.4.0 (#14775)
  • 50cd453 chore: Fix typos (#14868)
  • 4f81e07 Upgrade github.com/googleapis/enterprise-certificate-proxy to v0.3.4 (#14897)
  • 5aa3d82 TSDB: OOO native histograms: prep for multiple ooo head chunks (#14850)
  • 73e94dc Merge pull request #14899 from SuperSandro2000/patch-1
  • b93ed7b Merge pull request #14898 from prometheus/fix-targets-page-coloring
  • e8fa131 Merge pull request #14903 from jan--f/drop-agent-ff-docs
  • 62bd893 Merge pull request #14907 from prometheus/julius/new-ui-improvements
  • 31ce9da Merge pull request #14901 from roidelapluie/prebuiltui
  • d67ba3e Merge pull request #14908 from roidelapluie/fix14889
  • f007659 Merge pull request #14531 from prometheus/dependabot/go_modules/github.com/go-zookeeper/zk-1.0.4
  • 6febfbb put back feature flag 'delayed-compaction' and 'old-ui' (#14909)
  • 6acd3de Merge pull request #14913 from prometheus/explain-view-set-ops
  • b6015e7 Add support for running govulncheck (#12654)
  • 2c87817 Merge pull request #14914 from prometheus/julius/new-ui-improvements
  • 919dc0c storage: Update LabelQuerier interface to return sorted label values (#14849)
  • 14e3c05 tsdb: Add support for ingestion of out-of-order native histogram samples (#14546)
  • d5f4fab Merge pull request #14911 from bboreham/clarify-postings-benchmark
  • 00d23c9 Merge pull request #14915 from prometheus/dependabot/npm_and_yarn/web/ui/typescript-5.6.2
  • d1b4312 fix(wlog/watcher_test.go): make TestRun_AvoidNotifyWhenBehind more resilient
  • d0d57ff [DOC] Add username_file in basic auth http client config (#12749)
  • d90d097 fix(bstream/writeByte): ensure it appends only one byte (#14854)
  • 6c5e2f8 Merge pull request #12829 from arukiidou/chore/bump-webui
  • b8d1336 Merge pull request #14912 from roidelapluie/notready
  • c328d5f fix rwv2 build write request benchmark, also change how the memory usage (#14925)
  • bb47f78 Merge pull request #14505 from marioferh/improve_performance_regex
  • b6107cc Make rate possible non-counter annotation consistent (#14910)
  • c36589a Merge pull request #14940 from roidelapluie/subsecondzoom
  • c7fb618 Merge pull request #14930 from jan--f/holt-winters-experimental
  • df9916e Merge pull request #14677 from prometheus/beorn7/histogram
  • e480cf2 Merge pull request #14931 from prometheus/nexucis/autocomplete-topl
  • 005bd33 support v2 proto for BenchmarkSampleSend (#14935)
  • 5b9148e Merge pull request #14820 from charleskorn/promqltest-native-histogram-format
  • 9215252 [BUGFIX] TSDB: Only query chunks up to truncation time (#14948)
  • ca18f29 Merge pull request #14949 from Maniktherana/minor-fixes-ct
  • d42232e Merge pull request #14932 from bboreham/chunk-xor-combine-writebits
  • dfc6f4b Merge pull request #14945 from roidelapluie/submillis
  • 52fe4cc Merge pull request #14944 from roidelapluie/copy
  • 6bcb064 Merge pull request #14950 from Maniktherana/fuzz-om-minor-change
  • 31c5760 Neater string vs byte-slice conversions (#14425)
  • 919648c Merge pull request #14947 from roidelapluie/reloadinvalidyaml
  • f179cb9 chore: bump client_golang from 1.20.3 to 1.20.4 (#14963)
  • faf5ba2 Merge pull request #14959 from prometheus/merge-2.55-into-main
  • c2bbabb promql.Engine: Refactor vector selector evaluation into a method (#14900)
  • a0f26fe Merge pull request #12180 from damnever/perf/relabel-add-label
  • 67caa03 Merge pull request #14970 from prometheus/beorn7/doc
  • 5037cf7 Merge pull request #14972 from prometheus/jvp/make-mantime-ui-assets-relative
  • 5d8f0ef Merge pull request #14721 from bboreham/exp-grow-postings
  • 751100b Merge pull request #12998 from ringerc/docs-instant-vector-staleness
  • 5710ddf [ENHANCEMENT] Alerts: remove metrics for removed Alertmanagers (#13909)
  • d5f65cf Merge pull request #14694 from prometheus/ct-histogram
  • 79a6238 scrape/scrape_test.go: reduce the time it takes to reload the manager (#14447)
  • f747228 Merge pull request #14160 from alex-kattathra-johnson/issue-13959
  • 5f26d86 Merge pull request #14982 from prometheus/fix-remove-defunct-alert-close-buttons
  • 410fcce Remove unnecessary pprof import (#14988)
  • 7aa4721 Merge pull request #14946 from roidelapluie/notifications
  • 105ab2e fix(test): adjust defer invocations (#14996)
  • 54de4fb Merge pull request #14975 from colega/process-mempostings-delete-with-gomaxprocs-workers
  • 537c5db Merge pull request #14994 from roidelapluie/notifications2
  • 97f3219 test(discovery): add a Configs test showing that the custom unmarshalling/marshalling is broken.
  • b5569c4 fix(discovery): adjust how type is retrieved in Configs' MarshalYAML/UnmarshalYAML
  • b826c43 Calculate path prefix directly in initial settings Redux value (#14981)
  • 9bb7fab remove LeviHarrison as default maintainer (#15005)
  • d4423b1 Merge pull request #14992 from bboreham/remove-stubs
  • 7a90d73 sd k8s: test for sidecar container support in endpoints
  • a10dc92 sd k8s: support sidecar containers in endpoint discovery
  • 7399728 tests: update discovery tests with new labael
  • 77d3b3a OTLP: Remove experimental word form OTLP receiver (#14894)
  • c5c2566 MAINTAINERS: Add Arthur as an otlptranslator maintainer (#15024)
  • 4cb5f23 api: Improve doc comments for v1.MinTime and v1.MaxTime (#14986)
  • d745e76 Merge pull request #15048 from prometheus/dependabot/npm_and_yarn/web/ui/mantine/dates-7.13.1
  • f1f63a1 Merge pull request #15044 from prometheus/dependabot/npm_and_yarn/web/ui/react-router-dom-6.26.2
  • 8851388 Merge pull request #15041 from prometheus/dependabot/npm_and_yarn/web/ui/vitest-2.1.1
  • c43da57 Merge pull request #15051 from prometheus/dependabot/npm_and_yarn/web/ui/types/lodash-4.17.9
  • 357e64d Merge pull request #15050 from prometheus/dependabot/npm_and_yarn/web/ui/eslint-plugin-react-refresh-0.4.12
  • 72a0d2c Merge pull request #15047 from prometheus/dependabot/npm_and_yarn/web/ui/codemirror/view-6.34.1
  • 4d4fe3c Merge pull request #15066 from prometheus/dependabot/github_actions/scripts/actions/checkout-4.2.0
  • 764b122 Merge pull request #15067 from prometheus/dependabot/github_actions/github/codeql-action-3.26.10
  • 45efd01 Merge pull request #15052 from prometheus/dependabot/npm_and_yarn/web/ui/uiw/react-codemirror-4.23.3
  • 1b856bb Merge pull request #15037 from prometheus/dependabot/npm_and_yarn/web/ui/jsdom-25.0.1
  • afbe72f Merge pull request #15068 from prometheus/dependabot/github_actions/bufbuild/buf-setup-action-1.43.0
  • 8895883 Merge pull request #15053 from prometheus/dependabot/npm_and_yarn/web/ui/mantine/notifications-7.13.1
  • 6685222 Merge pull request #15054 from prometheus/dependabot/npm_and_yarn/web/ui/tanstack/react-query-5.59.0
  • cb89526 Merge pull request #15060 from prometheus/dependabot/npm_and_yarn/web/ui/mantine/code-highlight-7.13.1
  • 2605825 Merge pull request #15062 from prometheus/dependabot/npm_and_yarn/web/ui/eslint/js-9.11.1
  • 64c9909 Merge pull request #15063 from prometheus/dependabot/npm_and_yarn/web/ui/types/jest-29.5.13
  • 05668c5 Merge pull request #15059 from prometheus/dependabot/npm_and_yarn/web/ui/vite-5.4.8
  • fad9859 Merge pull request #15065 from prometheus/dependabot/github_actions/actions/setup-node-4.0.4
  • 9c0fe8e Merge pull request #15057 from prometheus/dependabot/npm_and_yarn/web/ui/codemirror/autocomplete-6.18.1
  • e32dbeb Merge pull request #15056 from prometheus/dependabot/npm_and_yarn/web/ui/eslint-9.11.1
  • 8fe5f36 Merge pull request #15058 from prometheus/dependabot/npm_and_yarn/web/ui/tabler/icons-react-3.19.0
  • 4edbe3f Merge pull request #15055 from prometheus/dependabot/npm_and_yarn/web/ui/globals-15.10.0
  • bcd9ce1 Merge pull request #15061 from prometheus/dependabot/npm_and_yarn/web/ui/postcss-8.4.47
  • 98cd80b feat: add microbenchmarks for OM CT parsing (#14933)
  • e99e7ca README: Update readme with API flag change for the otlp receiver (#15073)
  • f1c57a9 change: No longer ingest OM _created as timeseries if feature-flag 'enable-ct-zero-ingestion' is enabled; fixed OM text CT conversion bug (#14738)
  • 78f7921 Merge pull request #15025 from prometheus/notreset-bug
  • e1f8a79 Merge pull request #15069 from prometheus/allow-blank-issues
  • 20bf32b Merge pull request #15074 from jadolg/synchronized-RandomUnprivilegedPort
  • 199d2fb Merge pull request #14989 from NeerajGartia21/eval_info
  • 3a8131b Merge pull request #15032 from prometheus/dependabot/go_modules/go-opentelemetry-io-449d04d146
  • 34c0f2d Merge pull request #15029 from prometheus/dependabot/go_modules/documentation/examples/remote_storage/github.com/prometheus/common-0.60.0
  • d98c374 Merge pull request #15035 from prometheus/dependabot/go_modules/google.golang.org/api-0.199.0
  • 023146e Merge pull request #15082 from roidelapluie/notifystart
  • 47aeca9 feat: naive fixes and optimzations for CreatedTimestamp function (#14965)
  • 2976674 Merge pull request #15090 from roidelapluie/querylogrule
  • 4fc7b88 Merge pull request #15046 from prometheus/dependabot/go_modules/github.com/linode/linodego-1.41.0
  • a1c2f59 Merge pull request #15096 from prometheus/notification-style-cleanups
  • ab64966 fix: use "ErrorContains" or "EqualError" instead of "Contains(t, err.Error()" and "Equal(t, err.Error()" (#15094)
  • 5a54ae6 Bump actions/checkout from 4.1.6 to 4.2.0 (#15064)
  • 989db7b Merge pull request #15042 from prometheus/dependabot/go_modules/go.uber.org/automaxprocs-1.6.0
  • 8d281c3 textparse: Refactored benchmark (#15083)
  • 9d8f93e Merge pull request #15113 from yeya24/add-missing-allow-overlapping-compaction-flag
  • b3f6019 Merge pull request #15039 from prometheus/dependabot/go_modules/google.golang.org/grpc-1.67.1
  • a42e847 Merge pull request #15043 from prometheus/dependabot/go_modules/golang.org/x/tools-0.25.0
  • 1df86df Merge pull request #15117 from prometheus/dependabot/go_modules/golang.org/x/tools-0.26.0
  • 2b4ca98 Merge pull request #15038 from prometheus/dependabot/go_modules/github.com/gophercloud/gophercloud-1.14.1
  • f6e110d textparse: Refactored main testing utils for reusability; fixed proto Units. (#15095)
  • 65f6103 Merge pull request #15118 from roidelapluie/notificationsdoc
  • 805954d Merge pull request #14906 from tjhop/chore/3.0-adopt-slog
  • 24caa36 Merge pull request #15040 from prometheus/dependabot/go_modules/github.com/digitalocean/godo-1.126.0
  • e5f604e Merge pull request #15045 from prometheus/dependabot/go_modules/github.com/klauspost/compress-1.17.10
  • 7b6259b Merge pull request #15127 from roidelapluie/assets
  • 576000a Merge pull request #15111 from prometheus/beorn7/doc
  • 663a66b Merge pull request #11224 from dekimsey/consul-catalog-filter-support
  • 8650d25 Add additional basic nhcb unit tests (#15086)
  • 90f7832 Merge pull request #15084 from hvnsweeting/patch-1
  • 5e987e7 Merge pull request #15092 from jan--f/clarify-storage-contract
  • 02d0de9 Merge pull request #14997 from fionaliao/fl/update-format-docs
  • 720a259 Merge pull request #15135 from prometheus/beorn7/docs
  • 8b545ba Merge pull request #15026 from huochexizhan/main
  • 032ca9e [PERF] textparse: further optimzations for OM CreatedTimestamps (#15097)
  • d9a5428 Merge pull request #14987 from machine424/yafix
  • e6f9e2d Merge pull request #15119 from roidelapluie/dochttp
  • 50ef0dc Fix MemPostings.Add and MemPostings.Get data race (#15141)
  • 1e3953a Bump github.com/docker/docker (#15033)
  • 7ce9cfa Bump the k8s-io group with 3 updates (#15030)
  • 16bba78 discovery: Improve Azure test coverage to 50% (#14586)
  • b8867f8 Merge pull request #15142 from krajorama/fix-appendhistogram-race
  • c3b8582 [PERF] textparse: optimize OM p.isCreatedSeries() (#15150)
  • 522149a model: move classic NHCB conversion into its own file (#15156)
  • 911c3ef Merge pull request #14976 from prometheus/prep-3.0-beta.1
  • 1e1f6ab Merge pull request #15120 from bboreham/floor-ino-mint
  • d4b1f9e Corrects the behaviour of binary opperators between histogram and float (#14726)
  • 5541927 Merge pull request #15159 from prometheus/nhcb-scrape-optimize1
  • 08a7162 discovery: aws/ec2 unit tests (#14364)
  • 5a4e4f6 Fix stddev/stdvar when aggregating histograms, NaNs, and infinities (#14941)
  • 5dd5aec Merge pull request #14599 from machine424/sigsegv
  • 6ce21b8 Merge pull request #15172 from krajorama/update-client-golang
  • 2cabd1b config: remove expand-external-labels flag in release 3.0 (#14657)
  • efc43d0 s/scrape_classic_histograms/always_scrape_classic_histograms (3.0 breaking change) (#15178)
  • 763cbdf Merge pull request #15180 from prometheus/ooo-nh-corrupt-chunk
  • 754c104 Merge pull request #15173 from prometheus/merge-2.55-into-main-3
  • c78d5b9 Disallowing configure AM with the v1 api (#13883)
  • 5505c83 Merge pull request #15167 from machine424/impor
  • 421a3c2 scrape: provide a fallback format (#15136)
  • 98dcd28 Merge pull request #15170 from machine424/awldi
  • d8c1605 Merge pull request #15164 from machine424/quantile
  • 6b36a55 Merge pull request #14618 from machine424/para
  • 70e2d23 Merge pull request #11474 from clwluvw/group-label
  • d2802c6 api: Add rule group pagination to list rules api (#14017)
  • ad4857d Merge pull request #14978 from prometheus/nhcb-scrape-impl
  • 1b4e7f7 feat(tools): add debug printouts to rules unit testing (#15196)
  • 3bb5e28 Merge pull request #15197 from prometheus/alexg/docs-issue-11570
  • aa81210 NHCB scrape: refactor state handling and speed up scrape test (#15193)
  • 7c7116f Merge pull request #15176 from jhesketh/jhesketh/round
  • cccbe72 TSDB: Fix some edge cases when OOO is enabled (#14710)
  • 2182b83 feat(nhcb): implement created timestamp handling (#15198)
  • 469573b fix(nhcb): do not return nhcb from parse if exponential is present (#15209)
  • 3cb09ac Docs: Remove experimental note on out of order feature (#15215)
  • 07d01a9 Merge pull request #15219 from jan--f/rw-default-http2-off
  • 24a1052 Merge pull request #15205 from tjhop/chore/slog-fixes
  • f131cdd 3.0 migration guide (#15099)
  • 42a30a0 Merge pull request #15217 from CharlieTLe/support-int-exemplars
  • 93db81d Merge pull request #14983 from machine424/dopp
  • 372b83d Documented that WAL can still be written after memory-snapshot-on-shutdown (#15179)
  • bab587b Agent: allow for ingestion of CT samples (#15124)
  • eb3b349 fix(nhcb): created timestamp fails when keeping classic histograms (#15218)
  • 685d6d1 refactor: reorder fields in defaultSDConfig initialization for consistency
  • 7cda23b fix(lezer-promql): fix missing types export in package.json (#15161)
  • 99c0e68 Merge pull request #15230 from GiedriusS/optimize_resolvepodref
  • 559722d Merge pull request #15206 from multani/fix-doc-formatting
  • 706dcfe tsdb.CircularExemplarStorage: Avoid racing (#15231)
  • 350e0d5 Merge pull request #15228 from shenpengfeng/main
  • b6c5389 [REFACTORY] simplify appender commit (#15112)
  • d0eecb1 Merge pull request #15239 from colega/revert-14975-process-mempostings-delete-with-gomaxprocs-workers
  • 284135a Merge pull request #15223 from jan--f/release-3.0.0-rc.0
  • ccaff31 Merge pull request #15249 from prometheus/otlp-fix-sanitiza
  • dd4eb45 Merge pull request #15222 from jmichalek132/jm-add-tcp-events-to-tracing
  • e2e01c1 Merge pull request #15216 from yeya24/log-last-series-labels

machine424 and others added 30 commits October 28, 2024 22:53
* tsdb.CircularExemplarStorage: Avoid racing

---------

Signed-off-by: Arve Knudsen <[email protected]>
chore: fix function name in comment
* [REFACTOR] simplify appender commit

Signed-off-by: Nicolas Takashi <[email protected]>
Signed-off-by: Arthur Silva Sens <[email protected]>
Co-authored-by: George Krajcsovits <[email protected]>
Co-authored-by: Arthur Silva Sens <[email protected]>
…s-delete-with-gomaxprocs-workers

Revert "Process `MemPostings.Delete()` with `GOMAXPROCS` workers"
Signed-off-by: Juraj Michalek <[email protected]>
Signed-off-by: Juraj Michalek <[email protected]>
bugfix: Fix otlp translator for foreign characters
log last series labelset when hitting OOO series labels
…b.com/scaleway/scaleway-sdk-go-1.0.0-beta.30
…entation/examples/remote_storage/github.com/prometheus/client_golang-1.20.2
…b.com/digitalocean/godo-1.122.0

Signed-off-by: Arve Knudsen <[email protected]>
@aknuds1 aknuds1 force-pushed the arve/sync-upstream-individually branch from 9624637 to 6314392 Compare November 5, 2024 08:30
Also grafana/regexp sorts alternates alphabetically.

Signed-off-by: Bryan Boreham <[email protected]>
Signed-off-by: Bryan Boreham <[email protected]>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned all diffs between mimir-prometheus and upstream prometheus after this PR, and didn't spot any errors.
Also looked specifically at tsdb/head_append.go and model/labels/regexp_test.go.

@aknuds1 aknuds1 changed the title WIP: Sync with upstream Sync with upstream Nov 5, 2024
@aknuds1 aknuds1 requested a review from krajorama November 5, 2024 14:17
@aknuds1 aknuds1 marked this pull request as ready for review November 5, 2024 14:18
Copy link
Contributor

@krajorama krajorama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only noteworthy thing to me beside the regex matching change that we know about is the fact that this PR renames holt_winters PromQL function.

@colega
Copy link
Contributor

colega commented Nov 6, 2024

We should create an alias for holt_winters in Mimir.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Nov 6, 2024

We should create an alias for holt_winters in Mimir.

@colega Doing that in #743.

@colega
Copy link
Contributor

colega commented Nov 6, 2024

We don't really need to do that here in mimir-prometheus, IMO, it's a Mimir requirement, so should be done there.

@aknuds1
Copy link
Contributor Author

aknuds1 commented Nov 6, 2024

We don't really need to do that here in mimir-prometheus, IMO, it's a Mimir requirement, so should be done there.

@colega how can we do it in Mimir?

@colega
Copy link
Contributor

colega commented Nov 6, 2024

You can do it in Mimir through:

func init() {
	parser.Functions["holt_winters"] = parser.Functions["double_exponential_smoothing"]
	promql.FunctionCalls["holt_winters"] = promql.FunctionCalls["double_exponential_smoothing"]
}

@aknuds1
Copy link
Contributor Author

aknuds1 commented Nov 6, 2024

@colega hm yeah, maybe it is that simple. I'll check.

@aknuds1 aknuds1 merged commit 7ef8b5b into main Nov 6, 2024
23 checks passed
@aknuds1 aknuds1 deleted the arve/sync-upstream-individually branch November 6, 2024 17:30
@bboreham bboreham changed the title Sync with upstream Sync with upstream v3.0 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.