-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVP: Cost attribution #10269
Open
ying-jeanne
wants to merge
50
commits into
main
Choose a base branch
from
final-cost-attribution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
MVP: Cost attribution #10269
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
e315ebb
Poc: cost attribution proposal 2
ying-jeanne f04c28f
refectory
ying-jeanne 2c422d1
add experimental features in about-versioning.md
ying-jeanne d2eab6b
change const variable to private
ying-jeanne 1f39282
make timer service
ying-jeanne 9b4337d
rename TrackerForUser to Tracker
ying-jeanne 1a523e1
use fine locking
ying-jeanne f10f787
add comments explain why we use unchecked collector
ying-jeanne cc0e939
rename deleteUserTracker to deleteTracker
ying-jeanne c020be0
rename cat in cost attribution package to t or tracker
ying-jeanne 71e4666
avoid get tracker twice
ying-jeanne 9dd101b
refactor inactiveObservationsForUser
ying-jeanne 7d4ea9a
refactor shouldDelete function
ying-jeanne 6754666
rename calabels and calabelmap to labels and index
ying-jeanne fffc5b3
remove getter and setter of max cardinality and cooldown duration
ying-jeanne 2cf8c3e
rename CompareLabels to hasSameLabels
ying-jeanne f994034
remove the mapping logic since the slices are ordered
ying-jeanne b060c09
remove unnecessary tracker nil checking
ying-jeanne e35a8d9
fix linting
ying-jeanne 5cc0b5d
refactor updateOverflow method
ying-jeanne 389dff0
remove stream in comments
ying-jeanne 116a69e
make observation struct private
ying-jeanne 9c30445
remove unnecessary pointers
ying-jeanne 88ef49e
rename discardSampleMtx to discardedSampleMtx
ying-jeanne 130636a
rename variable observedMtx because I write with feet
ying-jeanne b701ba7
update test name dum dum
ying-jeanne dccd9c8
remove test result
ying-jeanne eebd028
address doc change
ying-jeanne 8386503
remove time checking
ying-jeanne d8f1e9b
add createIfDoesNotExist parameter
ying-jeanne b9efb94
add more condition for trigger newTracker
ying-jeanne a37e6de
remove the label adapter to labels call
ying-jeanne 211b3a2
remove useless function dum dum
ying-jeanne f697e6f
make hardcoded increment value
ying-jeanne fe8a1e5
rename + make cooldownuntil a normal int64 and lock with observedMtx
ying-jeanne 8b5836f
use build-in functon dum dum
ying-jeanne 888d8b0
modify the copy of calabels instead of directly the slice
ying-jeanne b15b487
update mimir-prometheus
ying-jeanne 87209d6
Merge remote-tracking branch 'origin/r322' into final-cost-attribution
ying-jeanne 4706bde
vendor new mimir-prometheus
ying-jeanne 1ab1f00
rename function
ying-jeanne 8111b6c
fix lint
ying-jeanne 17b64a9
add unittest in active series
ying-jeanne a191044
copy slice instead
ying-jeanne 2bb1845
add test for discarded samples
ying-jeanne ddd507d
change small map to slice since it is quicker
ying-jeanne b27e379
remove unused parameter
ying-jeanne a79fac7
add new parameter
ying-jeanne 37901b7
update config file
ying-jeanne f7115f4
Update pkg/costattribution/manager.go
ying-jeanne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not update mimir-prometheus here. It should be updated in
main
, and then you mergemain
into your branch.