Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting different annotations for headless service in the distributor #10485

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

allow setting different annotations for headless service in the distributor #10485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bae3ce6
add headless annotations for headless service annotations in distributor
KyriosGN0 Jan 20, 2025
4d12b13
update changelog
KyriosGN0 Jan 20, 2025
a22edb9
Update operations/helm/charts/mimir-distributed/CHANGELOG.md
dimitarvdimitrov Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions operations/helm/charts/mimir-distributed/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Entries should include a reference to the Pull Request that introduced the chang
* [CHANGE] Memcached: Update to Memcached 1.6.34. #10318
* [ENHANCEMENT] Minio: update subchart to v5.4.0. #10346
* [ENHANCEMENT] Individual mimir components can override their container images via the *.image values. The component's image definitions always override the values set in global `image` or `enterprise.image`. #10340
* [ENHANCEMENT] Allow setting different annotations for headless service in the distributor #10485
* [BUGFIX] Fix calculation of `mimir.siToBytes` and use floating point arithmetics. #10044

## 5.6.0
Expand Down
2 changes: 1 addition & 1 deletion operations/helm/charts/mimir-distributed/templates/distributor/distributor-svc-headless.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
annotations:
{{- toYaml .Values.distributor.service.annotations | nindent 4 }}
{{- toYaml .Values.distributor.service.headlessAnnotations | nindent 4 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. The setups that are currently in production, will stop working after they update to this one.

namespace: {{ .Release.Namespace | quote }}
spec:
type: ClusterIP
Expand Down
1 change: 1 addition & 0 deletions operations/helm/charts/mimir-distributed/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,6 +853,7 @@ distributor:

service:
annotations: {}
headlessAnnotations: {}
labels: {}
# -- https://kubernetes.io/docs/concepts/services-networking/service-traffic-policy/
internalTrafficPolicy: Cluster
Expand Down