Update make docs procedure
#10539
Merged
Update make docs procedure
#10539
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
type/docs
jdbaldry
approved these changes
Jan 30, 2025
jdbaldry
approved these changes
Feb 7, 2025
narqo
reviewed
Feb 14, 2025
docs/docs.mk
Outdated
| @@ -120,3 +120,10 @@ update: ## Fetch the latest version of this Makefile and the `make-docs` script | |||
| curl -s -LO https://raw.githubusercontent.com/grafana/writers-toolkit/main/docs/docs.mk | |||
| curl -s -LO https://raw.githubusercontent.com/grafana/writers-toolkit/main/docs/make-docs | |||
| chmod +x make-docs | |||
|
|
|||
| .PHONY: topic/% | |||
There was a problem hiding this comment.
(nit) Does make resolve % in the phony declarations? I thought the declaration is static so target/% doesn't make target/foo phony, no?
There was a problem hiding this comment.
No you're right, that's actually not gonna work if there's a topic/task file. I'll open a PR upstream to fix that behavior and you can expect an update to this PR in the next couple days
narqo
approved these changes
Feb 14, 2025
|
@narqo I don't have write permissions so feel free to merge this when you're happy :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test the changes, run the following and browse to URL output by the script: