Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE: add support for stddev_over_time and stdvar_over_time #10628

Merged
merged 7 commits into from
Feb 16, 2025
Merged

MQE: add support for stddev_over_time and stdvar_over_time #10628

merged 7 commits into from
Feb 16, 2025
+123 −28

Conversation

charleskorn
Copy link
Contributor

What this PR does

This PR adds support for stddev_over_time and stdvar_over_time to MQE.

Which issue(s) this PR fixes or relates to

#10067

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • [covered by Mimir Query Engine #10067] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn mentioned this pull request Feb 10, 2025
Open
@charleskorn charleskorn marked this pull request as ready for review February 12, 2025 05:04
@charleskorn charleskorn requested a review from a team as a code owner February 12, 2025 05:04
jhesketh
jhesketh reviewed Feb 14, 2025
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple of minor things :-)

pkg/streamingpromql/engine_test.go Show resolved Hide resolved
pkg/streamingpromql/operators/functions/range_vectors.go Outdated Show resolved Hide resolved
@charleskorn charleskorn enabled auto-merge (squash) February 14, 2025 06:09
jhesketh
jhesketh approved these changes Feb 16, 2025
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charleskorn charleskorn merged commit 61dfefa into main Feb 16, 2025
28 checks passed
@charleskorn charleskorn deleted the charleskorn/mqe-stdvar-stddev-over-time branch February 16, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskorn @jhesketh