Logging: detect log level through layers of wrappers #10646
+59
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the difference between Info and Debug logs. Signed-off-by: Bryan Boreham <[email protected]>
Make a Log() call so it reaches the bottom layer. If SlogFromGoKit is used with a logger outside of this package, you will get a spurious log line. Signed-off-by: Bryan Boreham <[email protected]>
dimitarvdimitrov
approved these changes
Feb 14, 2025
| // If we are called with a special magic struct, use it to pass back the logging level. | ||
| func (f levelFilter) Log(keyvals ...interface{}) error { | ||
| if len(keyvals) > 0 { | ||
| if x, ok := keyvals[len(keyvals)-1].(*privateLevelDetector); ok { |
There was a problem hiding this comment.
i'm shocked the type assertion doesn't make it significantly slower
|
for the record: I prefer this approach because the other one requires committers be aware of and keep the conventions in the package (of using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Expose log level through log wrappers, so that
Debug()calls are fast when debug logging is disabled.It works by making a
Log()call so it reaches the bottom layer.However, if
SlogFromGoKitis used with a logger outside of this package, you will get a spurious log line.Which issue(s) this PR fixes or relates to
Inspired by prometheus/prometheus#15993
This is a competitor to #10604. Credit @dimitarvdimitrov for the idea.
Before:
After:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.