Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention EKU requirements in securing-communications-with-tls.md #10648

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

martialblog
Copy link

What this PR does

This PR adds a sentence in the securing-communications-with-tls.md that mentions the EKU requirements for the certificates.

Let me know if I need to update the PR in any way. Thanks!

Which issue(s) this PR fixes or relates to

Fixes #10647

Checklist

  • Documentation added.

@martialblog martialblog requested review from tacole02 and a team as code owners February 14, 2025 12:06
@CLAassistant
Copy link

CLAassistant commented Feb 14, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@martialblog
Copy link
Author

This might also be valid for Loki and Tempo, but I haven't tested it.

@martialblog
Copy link
Author

Should I squash the commits myself or is it done on merge?

Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Mention required X509 extended key usage for TLS certificates
3 participants