Use new GitHub app in workflows instead of token #10650
Open
+125
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Feb 14, 2025
This reverts commit 5d97440.
narqo
reviewed
Feb 14, 2025
| - name: Download yq | ||
| uses: dsaltares/[email protected] | ||
| with: | ||
| repo: 'mikefarah/yq' | ||
| version: 'tags/v4.30.6' | ||
| file: 'yq_linux_amd64' | ||
| target: 'bin/yq' | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
For this one, and other similar cases below, do we have any problems with GITHUB_TOKEN, actually? This one is a short-lived token, auto generated by GitHub, only for the life-time of the action's execution (ref GitHub docs).
That is, GH_BOT_ACCESS_TOKEN is the PAT, that we SHOULD to get rid of. The GITHUB_TOKEN IS fine, as it's managed by GitHub, isn't it?
Comment on lines
43
to
-27
| gh pr review $PR_URL \ | ||
| --approve -b "**I'm approving** this pull request, since it is a helm release." | ||
| env: | ||
| PR_URL: ${{github.event.pull_request.html_url}} | ||
| GITHUB_TOKEN: ${{secrets.GH_BOT_ACCESS_TOKEN}} |
There was a problem hiding this comment.
BTW, today this doesn't work, because grafanabot (the principal of GH_BOT_ACCESS_TOKEN) is trying to approve its own PR 🤖
Do you happen to know if, after we update to a GH app, this will use different principals for opening a PR, and an auto-approval?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the same GitHub app as the one we use in backend-enterprise. This should allow us to stop using the GitHub token we were previously using.