Simplify how experimental PromQL functions are enabled #10660
+39
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💻 Deploy preview available: https://deploy-preview-mimir-10660-zb444pucvq-vp.a.run.app/docs/mimir/latest/ |
Remove experimental configuration flags `querier.promql-experimental-functions-enabled` and `query-frontend.block-promql-experimental-functions` used for controlling access to experimental PromQL features. Instead enable experimental PromQL functions at the engine level by default, block access to them by default, and selectively enable them at a per-user level using the middleware introduced in #9798. Justification for this change: * There are currently 3 different settings that need to changed to allow customers to make use experimental functions in PromQL that need to be applied 3 differnt places (queriers, query-frontend, and per-tenant limits). * The performance impact from always enabling but blocking via middleware experimental PromQL functions (what this PR does) is so small that it does not show up in profling from what I can tell. Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/exp-config-cleanup
branch
from
7f8fad7 to
000554d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Remove experimental configuration flags
querier.promql-experimental-functions-enabledandquery-frontend.block-promql-experimental-functionsused for controlling access to experimental PromQL features. Instead enable experimental PromQL functions at the engine level by default, block access to them by default, and selectively enable them at a per-user level using the middleware introduced in #9798.Justification for this change:
Which issue(s) this PR fixes or relates to
Related #9798
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.