Add ad hoc filters before sending Lucene queries to backend #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 27, 2023
fridgepoet
requested review from
iwysiu and
idastambuk
and removed request for
a team
fridgepoet
changed the title
idastambuk
approved these changes
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For Lucene queries which were recently migrated to the backend, this fixes ad hoc filters on queries which were redirected to the backend as part of this plugin's migration to a backend data source.
Ad hoc filters were only added in the frontend while building the query, so this code was not reached when diverting queries to the backend.
Here is a recording of this PR's behavior:
Screen.Recording.2023-07-31.at.13.00.55.mov
Which issue(s) this PR fixes:
Fixes #224
Special notes for your reviewer:
This PR should revert the behavior to the same as in v2.6.2 and before.
Ad hoc filtering will not return data for nested documents as this is not supported in the Lucene query language.
Thank you @idastambuk for all your help on this one!