-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: Remove _doc from sort array in query building, Remove limit from response processing, Prepare release v2.13.1 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
changed the title
Clean logs
Backend: Harmonize Lucene logs to better match frontend
Oct 5, 2023
fridgepoet
changed the title
Backend: Harmonize Lucene logs to better match frontend
Backend: Harmonize Lucene logs query building and response processing with frontend's
Oct 5, 2023
fridgepoet
changed the title
Backend: Harmonize Lucene logs query building and response processing with frontend's
Backend: Harmonize Lucene logs query building and response processing with frontend's, Prepare release v2.13.1
Oct 6, 2023
fridgepoet
changed the title
Backend: Harmonize Lucene logs query building and response processing with frontend's, Prepare release v2.13.1
Backend: Remove extra _doc from sort array in query building, Prepare release v2.13.1
Oct 9, 2023
fridgepoet
changed the title
Backend: Remove extra _doc from sort array in query building, Prepare release v2.13.1
Backend: Remove extra _doc from sort array in query building, Remove limit from response processing, Prepare release v2.13.1
Oct 9, 2023
This reverts commit ae22140.
fridgepoet
requested review from
iwysiu and
sarahzinger
and removed request for
a team
October 9, 2023 10:54
fridgepoet
changed the title
Backend: Remove extra _doc from sort array in query building, Remove limit from response processing, Prepare release v2.13.1
Backend: Remove _doc from sort array in query building, Remove limit from response processing, Prepare release v2.13.1
Oct 9, 2023
sarahzinger
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR addresses any difference between the frontend and backend query building and response processing to Grafana data frames for Lucene logs.
The only change in this PR is in bold text.
Difference list:
Query building to OpenSearch:
{"_doc":{"order":"desc"}}
which is not present in the frontend. This came from the equivalent backend migration PR of Elasticsearch, but I don't see evidence of_doc
anymore in the latest OpenSearch documentation. In any case since this is not present in the frontend, this was removed.Grafana data frame response:
Which issue(s) this PR fixes:
Contributes to #199
Special notes for reviewers:
Testing was done locally by including the changes from this branch: https://github.com/grafana/opensearch-datasource/tree/backend-flow
This redirects all Lucene queries to the backend (not just from the Explore view).