CI: Run e2e tests against two Grafana versions by sunker · Pull Request #1419 · grafana/plugin-tools

sunker · 2024-12-19T08:57:24Z

What this PR does / why we need it:

This PR extends the CI workflow so that the e2e tests are not only run against the latest version of Grafana, but also against the lowest supported Grafana version. In addition to that, the reports are now being deployed to GH pages.

Note that I have forced two tests to fail just to showcase what it looks like (see PR comment below).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

github-actions · 2024-12-19T08:57:45Z

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs.

CLAassistant · 2024-12-20T07:27:23Z

All committers have signed the CLA.

CLAassistant · 2024-12-20T07:27:24Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ sunker
❌ grafanabot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

sunker · 2024-12-20T12:45:47Z

  /* Retry on CI only */
  retries: process.env.CI ? 2 : 0,
-  /* Opt out of parallel tests on CI. */
-  workers: process.env.CI ? 1 : undefined,


This speeds up the CI process a bit. Seems to work fine in GH workflows

mckn

LGTM! Should we also add a check if MIN_VERSION and LATEST_VERSION is the same, then we probably can skip running MIN_VERSION tests.

sunker · 2025-01-31T07:41:42Z

LGTM! Should we also add a check if MIN_VERSION and LATEST_VERSION is the same, then we probably can skip running MIN_VERSION tests.

@mckn I don't think it can be the same. We set grafanaDependency manually and it should always be the last minor of the previous major.

+        working-directory: ./${{ matrix.workingDir }}
+
+      - name: Wait for grafana server (${{ steps.min-version.outputs.MIN_VERSION }})
+        uses: grafana/plugin-actions/wait-for-grafana@main


        working-directory: ./${{ matrix.workingDir }}

-      - name: Wait for grafana server
+      - name: Wait for grafana server (latest)


+    steps:
+      - uses: actions/checkout@v4
+      - name: Publish report
+        uses: grafana/plugin-actions/playwright-gh-pages/deploy-report-pages@main


This reverts commit 54bf129.

This reverts commit 055c2cb.

        working-directory: ./${{ matrix.workingDir }}

+      - name: Upload e2e test summary (latest)
+        uses: grafana/plugin-actions/playwright-gh-pages/upload-report-artifacts@main


+        working-directory: ./${{ matrix.workingDir }}
+
+      - name: Upload e2e test summary (${{ steps.min-version.outputs.MIN_VERSION }})
+        uses: grafana/plugin-actions/playwright-gh-pages/upload-report-artifacts@main


mckn

LGTM!

This reverts commit 6fe7a2a.

This reverts commit d1b7781.

sunker added the no-changelog Don't include in changelog and version calculations label Dec 19, 2024

sunker force-pushed the create-plugin/include-lower-bound branch 5 times, most recently from 45f43a7 to 2ab7203 Compare December 19, 2024 14:14

sunker force-pushed the create-plugin/include-lower-bound branch 3 times, most recently from 5389546 to 522daa0 Compare December 20, 2024 12:45

sunker commented Dec 20, 2024

View reviewed changes

sunker marked this pull request as ready for review January 14, 2025 14:26

sunker requested a review from a team as a code owner January 14, 2025 14:26

sunker requested review from jackw, leventebalogh and oshirohugo January 14, 2025 14:26

mckn reviewed Jan 15, 2025

View reviewed changes

tolzhabayev assigned sunker Jan 30, 2025

sunker force-pushed the create-plugin/include-lower-bound branch from 522daa0 to 6d5bfb2 Compare January 31, 2025 07:42

github-advanced-security AI found potential problems Jan 31, 2025

View reviewed changes

target oldest and latest supported versions

4d9c64f

github-advanced-security AI found potential problems Feb 3, 2025

View reviewed changes

sunker added 5 commits February 3, 2025 09:52

let playwright decide how many workers to use

c9d5158

temp: trigger a failure in min version

a7874a6

log grafanaversion

e7b19a6

set vars on build

175091a

Revert "log grafanaversion"

fa06c47

This reverts commit 54bf129.

sunker added 2 commits February 3, 2025 09:52

Revert "temp: trigger a failure in min version"

ee26a95

This reverts commit 055c2cb.

use new actions

01013b4

sunker force-pushed the create-plugin/include-lower-bound branch from 1c98109 to 01013b4 Compare February 3, 2025 08:53

sunker added 4 commits February 3, 2025 10:15

force some tests to fail

d1b7781

change strategy

09e4f8b

fail due to errors

eb2a7cb

use right condition

a3c512b

github-advanced-security AI found potential problems Feb 3, 2025

View reviewed changes

sunker added 5 commits February 3, 2025 11:38

use working dir

8675b20

add plugin name

6e451fb

use right version

92b3718

echo event number

a303a88

change triggers

fe4803f

sunker requested a review from mckn February 3, 2025 11:52

force another version to fail

6fe7a2a

sunker mentioned this pull request Feb 3, 2025

Playwright: Use new GH Pages actions #1504

Merged

mckn approved these changes Feb 3, 2025

View reviewed changes

sunker added 2 commits February 3, 2025 18:58

Revert "force another version to fail"

65f754f

This reverts commit 6fe7a2a.

Revert "force some tests to fail"

4707027

This reverts commit d1b7781.

sunker merged commit fc67153 into main Feb 3, 2025

sunker deleted the create-plugin/include-lower-bound branch February 3, 2025 18:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Run e2e tests against two Grafana versions#1419

CI: Run e2e tests against two Grafana versions#1419
sunker merged 20 commits intomainfrom
create-plugin/include-lower-bound

sunker commented Dec 19, 2024 •

edited

Loading

Uh oh!

github-actions Bot commented Dec 19, 2024 •

edited

Loading

Uh oh!

CLAassistant commented Dec 20, 2024 •

edited

Loading

Uh oh!

CLAassistant commented Dec 20, 2024

Uh oh!

sunker Dec 20, 2024

Uh oh!

mckn left a comment

Uh oh!

sunker commented Jan 31, 2025

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

mckn left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

sunker commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Dec 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Dec 20, 2024

Uh oh!

sunker Dec 20, 2024

Choose a reason for hiding this comment

Uh oh!

mckn left a comment

Choose a reason for hiding this comment

Uh oh!

sunker commented Jan 31, 2025

Uh oh!

Uh oh!

Check warning

Uh oh!

Check warning

Uh oh!

Uh oh!

Check warning

Check warning

Check warning

mckn left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sunker commented Dec 19, 2024 •

edited

Loading

github-actions Bot commented Dec 19, 2024 •

edited

Loading

CLAassistant commented Dec 20, 2024 •

edited

Loading