Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenes App: Update to use react-router v6 #1422

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Scenes App: Update to use react-router v6 #1422

wants to merge 1 commit into from

Conversation

leventebalogh
Copy link
Collaborator

@leventebalogh leventebalogh commented Dec 19, 2024 •
edited by grafana-plugins-platform-bot bot
Loading

Related PR: grafana/scenes#979

Note

This PR is still using the 6.0.0--canary.979.12373078054.0 canary version of the @grafana/scenes package. It will get updated once the major version goes out.

What changed?

This PR updates the scaffolded scenes-app template to use the v6 version of react-router as well.

  • Changed to use <Routes> instead <Switch>
  • Changed to use relative route paths and trailing /*s for wildcard routes (routes are now exact by default)
  • Updated to use react-router v6
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]

@leventebalogh leventebalogh added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Dec 19, 2024
@leventebalogh leventebalogh self-assigned this Dec 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 19, 2024 •
edited
Loading

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@leventebalogh leventebalogh mentioned this pull request Dec 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@leventebalogh leventebalogh

Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged
Projects
Plugins Platform / Grafana Community
Status: 🔬 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leventebalogh