-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: How to version UI extensions #1521
Conversation
Hello! 👋 This repository uses Auto for releasing packages using PR labels. ✨ This PR can be merged. It will not be considered when calculating future versions of the npm packages and will not appear in the changelogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice doc! A question and a few minor style nits, otherwise LGTM. For future reference, emphasis isn't so necessary -- and we use italics instead of bold for emphasis.
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
…ons.md Co-authored-by: Joseph Perez <[email protected]>
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one @mckn 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is looking good! I've made a few comments and suggestions which I would appreciate your thoughts on prior to merging
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
|
||
Each extension point ID/component ID should include a suffix indicating the major version of the extension. | ||
|
||
**Example:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking - it would be nice to have both an extension point and component example to be more explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I started on this and it gets a bit complex to include it in the docs. I will create an issue adding it to examples (not sure I will have time before parental leave) and then reference that example in this doc. Sounds ok?
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
docusaurus/docs/how-to-guides/ui-extensions/versioning-extensions.md
Outdated
Show resolved
Hide resolved
…ons.md Co-authored-by: David Harris <[email protected]>
…ons.md Co-authored-by: David Harris <[email protected]>
…ons.md Co-authored-by: David Harris <[email protected]>
…ons.md Co-authored-by: David Harris <[email protected]>
…ons.md Co-authored-by: David Harris <[email protected]>
…ons.md Co-authored-by: David Harris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good approach. This will take some coordination to start using.
I'm thinking we can start by adding /v1 to all our machine-learning exposed extension points, and leave the current ones there also, then ask other teams consuming our extensions to swap over to the /v1 version.
It'll be a good way to get everyone used to it.
Thanks for doing this, it'll help us a lot when introducing changes that could have impact in lots of places.
Super! We decided to consider the grafana-core extension points as |
What this PR does / why we need it:
This aims to provide some good guide lines for how to version your extension points to allow plugin authors to change the extensions without breaking any plugins consuming the extension point.
Todo:
Which issue(s) this PR fixes:
Fixes grafana/grafana#92202
Fixes #
Special notes for your reviewer: