Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "recommendation" severity analyzer #309

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Add "recommendation" severity analyzer #309

merged 1 commit into from
Feb 18, 2025

Conversation

academo
Copy link
Member

@academo academo commented Feb 17, 2025 •
edited
Loading

Adds a "Recommendation" category for validators.

@academo academo requested review from a team as code owners February 17, 2025 14:35
@academo academo requested review from oshirohugo, wbrowne and andresmgot and removed request for a team February 17, 2025 14:35
xnyo
xnyo approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@xnyo xnyo left a comment •
edited by academo
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

You also have to update the community-pipeline to support the new value:

jackw
jackw approved these changes Feb 17, 2025
View reviewed changes
Copy link

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@academo academo merged commit c18a347 into main Feb 18, 2025
2 checks passed
@academo academo deleted the academo/add-recommended-validators branch February 18, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackw jackw jackw approved these changes

@xnyo xnyo xnyo approved these changes

@oshirohugo oshirohugo Awaiting requested review from oshirohugo oshirohugo is a code owner automatically assigned from grafana/plugins-platform-frontend

@wbrowne wbrowne Awaiting requested review from wbrowne wbrowne is a code owner automatically assigned from grafana/plugins-platform-backend

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

Assignees
No one assigned
Labels
None yet
Projects
Plugins Platform / Grafana Community
Status: 🚀 Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@academo @jackw @xnyo