-
Notifications
You must be signed in to change notification settings - Fork 622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds proper support for goroutines, block, mutex profiling #1178
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
- Coverage 69.41% 69.37% -0.04%
==========================================
Files 98 98
Lines 3210 3212 +2
Branches 836 837 +1
==========================================
Hits 2228 2228
- Misses 978 980 +2
Partials 4 4
Continue to review full report at Codecov.
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
// TODO(petethepig): technically block profiles have the same name | ||
// so this might be a block profile, need better heuristic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, it won't be a big problem: in pull mode we have a correct mapping, while push API allows specifying it in an explicit way
Corresponding PR on the client side: grafana/pyroscope-go#15
To enable this in pull mode:
Caveat is that mutex and block profiling requires an extra step: