fix: wrap groupBy single-select value in an array #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -340,9 +340,9 @@ export function GroupByVariableRenderer({ model }: SceneComponentProps<MultiValu | |||
| } | |||
| return; | |||
| } | |||
| if (newValue?.value) { | |||
| if (newValue?.value && newValue?.label) { | |||
There was a problem hiding this comment.
don't think you want this extra condition. label is optional
There was a problem hiding this comment.
I was trying to avoid the !
}
if (newValue?.value) {
setUncommittedValue([newValue]);
model.changeValueTo([newValue.value], [newValue.label!]);
}
There was a problem hiding this comment.
maybe something like:
if (newValue?.value) {
setUncommittedValue([newValue]);
model.changeValueTo([newValue.value], newValue.label ? [newValue.label] : undefined);
}would work then
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use the Single select in db-o11y, realized we were sending incorrect data format.
"error": "json: cannot unmarshal string into Go struct field internalQueryModel.groupByKeys of type []string",In this PR I'm wrapping the value in an array.