-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdHocFiltersVariable: provide updateFilters method to allow updating filters without emitting SceneVariableValueChangedEvent #1004
Merged
gtk-grafana
merged 10 commits into
main
from
gtk-grafana/ad-hoc-variable-skip-publish-on-setstate
Dec 20, 2024
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
23678ab
feat: allow caller to skip emitting SceneVariableValueChangedEvent
gtk-grafana 36b07af
test: add test coverage
gtk-grafana 5bf94a2
chore: run prettier
gtk-grafana b99db18
feat: add updateFilters method instead of polluting setState interface
gtk-grafana 42661b0
chore: run prettier
gtk-grafana cdffe34
chore: DRY up setState & updateFilters
gtk-grafana 2b93993
chore: run prettier
gtk-grafana a170789
chore: add forcepublish option, fix filter expression check
gtk-grafana 051229a
chore: update updateFilters to take filters as input
gtk-grafana ced54ec
chore: prettier
gtk-grafana File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should adjust updateFilters to:
and then reuse that in the setState so we don't get out of sync on functions and have a single source of truth for updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, this change is implemented in cdffe34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with this.
updateFilters
should update filters, not entire state of the object. What i think is needed here is to remove thesetState
overload all together. If someone want's to update filters (and control behavior of such updatr), then we have an API for that. If someone wants to update the state, then they can rely on the base class'ssetState
(without side effect of the event being published). This is a breaking change, hence i suggested adding release notes :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dprokop, the setState overload has been reverted, but I kept the option to force the publish in the updateFilters.