Variables: current value #1005
Open
Variables: current value #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
torkelo
reviewed
Dec 18, 2024
Comment on lines
328
to
339
| public getOptionsForSelect(): VariableValueOption[] { | ||
| public getOptionsForSelectWithoutCurrentValue(): VariableValueOption[] { | ||
| let options = this.state.options; | ||
|
|
||
| if (this.state.includeAll) { | ||
| options = [{ value: ALL_VARIABLE_VALUE, label: ALL_VARIABLE_TEXT }, ...options]; | ||
| } | ||
|
|
||
| return options; | ||
| } | ||
|
|
||
| public getOptionsForSelect(): VariableValueOption[] { | ||
| let options = this.getOptionsForSelectWithoutCurrentValue(); |
There was a problem hiding this comment.
looks simper to just have an optional param for getOptionsForSelect(includeCurrentValue?: boolean)
There was a problem hiding this comment.
thanks for your review. i modified getOptionsForSelect and add one parameter. please take a look.
|
@torkelo bro ,could you please take a look this pr, i followed you comment and modified code, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes grafana/grafana#98005
i think the variable edit page don't need current value to show. so i add a function
getOptionsForSelectWithoutCurrentValue.after this pr merged. i would change this line (https://github.com/grafana/grafana/blob/main/public/app/features/dashboard-scene/settings/variables/VariableEditorForm.tsx#L116) to use
getOptionsForSelectWithoutCurrentValue