Variables: Add datasource variable support #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
release
|
@sunker added release label and minor to this PR, there should be a canary release shortly added to this PR (in the main description), you can use that canary to test this PR in the main repo |
torkelo
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
@sunker thanks for this! had no idea we had this additional type of variable support implementation, so we completely missed it.
Is it commonly used? Do you know a few datasources that use it? Strange that it has only surfaced now :)
|
No it's not commonly used, but it's only because the VariableSupportAPI has been undocumented since it was introduced four years ago. We have on our todolist to change that. I just happened to notice that this part of the api is broken. |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempt to fix this issue.
I'm not very familiar with the scenes framework or its tooling so would appreciate some guidance on how the proposed solution and also on the next steps.