fix: groupBy manual applyMode #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelavargas
reviewed
Dec 19, 2024
There was a problem hiding this comment.
Hey @joannaWebDev 😊, great work with this one 🏅 , can you add a unit test for this scenario, https://github.com/grafana/scenes/blob/main/packages/scenes/src/variables/groupby/GroupByVariable.test.tsx
Sure thing. Done |
axelavargas
approved these changes
Dec 19, 2024
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the GroupByVariable where the applyMode property was not being respected. Specifically, the addActivationHandler logic ran regardless of the applyMode value, causing unintended behavior.
To address this, we introduced a conditional check for
this.state.applyMode === 'auto'before invoking addActivationHandler. This ensures that activation logic only applies when the applyMode is set to auto.Changes have been tested locally using
npm link --force ../scenes/packages/scenes.Demo
demo.mov