Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdHocFilters: Fix matching non-latin template vars in filter #1018

Merged
merged 2 commits into from
Dec 31, 2024
Merged

AdHocFilters: Fix matching non-latin template vars in filter #1018

merged 2 commits into from
Dec 31, 2024

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Dec 30, 2024 •
edited by scenes-repo-bot-access-token bot
Loading

fix for searching non-latin tpl vars.

see grafana/grafana#83806 (comment)

related non-scenes PR: grafana/grafana#98416

📦 Published PR as canary version: 5.36.1--canary.1018.12559811683.0

✨ Test out this PR locally via:

npm install @grafana/[email protected]
npm install @grafana/[email protected]
# or 
yarn add @grafana/[email protected]
yarn add @grafana/[email protected]

@leeoniya leeoniya mentioned this pull request Dec 30, 2024
Closed
Sergej-Vlasov
Sergej-Vlasov approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Sergej-Vlasov Sergej-Vlasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! 👍

Just run yarn prettier:write to pass the prettier check we introduced recently

packages/scenes/src/variables/adhoc/AdHocFiltersCombobox/utils.ts
@@ -11,11 +11,19 @@ export const VIRTUAL_LIST_ITEM_HEIGHT = 38;
export const VIRTUAL_LIST_ITEM_HEIGHT_WITH_DESCRIPTION = 60;
export const ERROR_STATE_DROPDOWN_WIDTH = 366;

export function fuzzySearchOptions(options: Array<SelectableValue<string>>) {
// https://catonmat.net/my-favorite-regex :)
const REGEXP_NON_ASCII = /[^ -~]/m;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Sergej-Vlasov Sergej-Vlasov added patch Increment the patch version when merged release Create a release when this pr is merged area/variables Issues related to variables system in scenes labels Dec 31, 2024
@leeoniya leeoniya merged commit bd2ba60 into main Dec 31, 2024
4 checks passed
@leeoniya leeoniya deleted the leeoniya/fix-non-latin-var-filter branch December 31, 2024 12:55
@scenes-repo-bot-access-token
Copy link

🚀 PR was released in v5.36.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sergej-Vlasov Sergej-Vlasov Sergej-Vlasov approved these changes

Assignees
No one assigned
Labels
area/variables Issues related to variables system in scenes patch Increment the patch version when merged release Create a release when this pr is merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeoniya @Sergej-Vlasov