SceneShareLinksButton: expose share links button to scene apps#1022
Open
gtk-grafana wants to merge 1 commit intomainfrom
Open
SceneShareLinksButton: expose share links button to scene apps#1022gtk-grafana wants to merge 1 commit intomainfrom
gtk-grafana wants to merge 1 commit intomainfrom
Conversation
gtk-grafana
added
usecase/app-plugins
dprokop
reviewed
Feb 23, 2026
Collaborator
dprokop
left a comment
dprokop
left a comment
There was a problem hiding this comment.
I wonder, this ain't very framework-ish component. Why do we even need it in scenes library?
| key: string; | ||
| label: string; | ||
| icon: IconName; | ||
| getUrl: Function; |
Collaborator
There was a problem hiding this comment.
shouldn't this be () => string | undefined?
| public onCopyLink(shorten: boolean, absTime: boolean, url?: string) { | ||
| if (shorten) { | ||
| createAndCopyShortLink(url || global.location.href); | ||
| reportInteraction('grafana_explore_shortened_link_clicked', { isAbsoluteTime: absTime }); |
Collaborator
There was a problem hiding this comment.
you are leaking explore specific interactions reporting to scenes, not nice ;)
| : global.location.href | ||
| ); | ||
|
|
||
| if (this.state.onCopyLink) { |
Collaborator
There was a problem hiding this comment.
this won't be called if someone wants a shortened link. is this expected?
| const url = lastSelected.getUrl(); | ||
| model.onCopyLink(lastSelected.shorten, lastSelected.absTime, url); | ||
| }} | ||
| aria-label={'Copy shortened URL'} |
Collaborator
There was a problem hiding this comment.
think this needs sth like lastSelected.label, otherwise this can be innacurate label.
| <Dropdown | ||
| overlay={<SceneShareLinksButton.MenuActions model={model} />} | ||
| placement="bottom-end" | ||
| onVisibleChange={model.setIsOpen.bind(model)} |
Collaborator
There was a problem hiding this comment.
nit - this is a new function created on every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
SceneShareLinksButtonscene for scene apps.SceneShareLinksButton allows consumers to define:
onCopyLinkcallback (for tracking) on link copygetSceneTimeRangefunction to specify whichSceneTimeRangeLikeshould be used for the link generation.