Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dev: link to all @grafana modules in core #1076

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Mar 19, 2025

  • updates the linking script to link to all @grafana core modules
  • this removes the need for webpack aliasing in core when linking scenes locally to core
  • adds a cleanup function to cleanup the links once the script shuts down
  • adds systemjs types to devdeps to resolve the systemjs types used in data and runtime correctly otherwise this repo falls back to declarations in testing-library and gets grumpy 😠
  • see related PR in core

@ashharrison90 ashharrison90 requested a review from a team March 19, 2025 13:03
@ashharrison90 ashharrison90 self-assigned this Mar 19, 2025
@ashharrison90 ashharrison90 requested review from axelavargas and harisrozajac and removed request for a team March 19, 2025 13:03
@ashharrison90 ashharrison90 requested a review from jackw March 19, 2025 13:03
@jackw jackw added dependencies Update one or more dependencies version no-changelog labels Mar 19, 2025
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me and appears to work locally for me even with the TS errors coming from grafana core dev builds. Pretty sure the issue is this types pointing to source code which the ForkTsChecker in core Grafana then picks up. We either change that to point to the d.ts files which would also improve type checking performance everywhere scenes is used OR we update scenes to use the new jsx transform / make it aligned with the tsconfig settings in core grafana.

Would be best to get an additional review from someone that knows the library better before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update one or more dependencies version no-changelog
Projects
Status: 🔍 In review
Development

Successfully merging this pull request may close these issues.

3 participants