SceneTimeRange: Add weekStart support and make sure fiscalYearMonth is used everywhere #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
torkelo
commented
Sep 29, 2023
•
torkelo
commented
- Adds weekStart support (needed for core dashboards)
- Make sure we pass fiscalYearMonth everywhere
torkelo
added
minor
torkelo
changed the title
3 tasks
dprokop
approved these changes
Sep 29, 2023
| @@ -142,6 +142,8 @@ export interface SceneTimeRangeState extends SceneObjectState { | |||
| fiscalYearStartMonth?: number; | |||
| value: TimeRange; | |||
| timeZone?: TimeZone; | |||
| /** weekStart will change the global date locale so having multiple different weekStart values is not supported */ | |||
There was a problem hiding this comment.
Was going to add a comment about that until I came here :D
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.