AdhocFilters: Add docs for AdhocFilterSet and AdhocFiltersVariable #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatwawana
reviewed
Sep 29, 2023
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
dprokop
approved these changes
Oct 3, 2023
Comment on lines
+24
to
+26
| // You don't need to set baseFilters, but they're useful if you want to limit label suggestions to only those you deem relevant for the scene. | ||
| // These are not shown in the UI. | ||
| baseFilters: [{ key: '__name__', operator: '=', value: 'ALERTS', condition: '' }], |
There was a problem hiding this comment.
An example would be useful for this property
There was a problem hiding this comment.
@dprokop the code your commenting on is the example (a very useful example of limiting keys to those of a specific metrics name)
Co-authored-by: Dominik Prokop <[email protected]>
Co-authored-by: Dominik Prokop <[email protected]>
Co-authored-by: Dominik Prokop <[email protected]>
Co-authored-by: Dominik Prokop <[email protected]>
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs!