Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables: Add Uppercase variable support to formatRegistry.ts #746

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Variables: Add Uppercase variable support to formatRegistry.ts #746

wants to merge 2 commits into from

Conversation

hoobtron
Copy link

@hoobtron hoobtron commented May 24, 2024 •
edited by axelavargas
Loading

New text to uppercase FormatRegistryItem

belongs to grafana/grafana#88281

Fixes: #441

@hoobtron
Update formatRegistry.ts
b383ef4 
new Text to uppercase FormatRegistryItem
@CLAassistant
Copy link

CLAassistant commented May 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@hoobtron hoobtron mentioned this pull request May 24, 2024
Closed
4 tasks
@axelavargas axelavargas requested review from a team, bfmatei and mdvictor and removed request for a team September 12, 2024 09:58
bfmatei

This comment was marked as outdated.

Sign in to view

bfmatei
bfmatei requested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@bfmatei bfmatei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking back to the original item, I see that the tests are in a separate PR. Can you include them here as well?

@bfmatei bfmatei added patch Increment the patch version when merged release Create a release when this pr is merged labels Sep 12, 2024
@axelavargas axelavargas mentioned this pull request Sep 24, 2024
Closed
@hoobtron
Copy link
Author

hoobtron commented Oct 1, 2024

done (PR 747 merged into 746)

@axelavargas axelavargas requested a review from bfmatei October 2, 2024 09:44
axelavargas
axelavargas approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@axelavargas axelavargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me 🏅

Also, I am attaching some context to know why we are adding the new TextUpper support.

#441 (comment)

@axelavargas axelavargas changed the title Update formatRegistry.ts Variables: Add Uppercase variable support to formatRegistry.ts Oct 2, 2024
@axelavargas axelavargas added the area/variables Issues related to variables system in scenes label Oct 2, 2024
@axelavargas
Copy link
Member

@hoobtron 👋🏾 , can you update your branch with the latest main, the CI is failing 😕

@axelavargas
Copy link
Member

Hey @hoobtron 👋🏾 , friendly reminder about this: 😄

can you update your branch with the latest main, the CI is failing 😕

@mdvictor mdvictor removed their request for review October 14, 2024 09:01
@robhamnett
Copy link

this would be a super helpful feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelavargas axelavargas axelavargas approved these changes

@bfmatei bfmatei Awaiting requested review from bfmatei

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/variables Issues related to variables system in scenes patch Increment the patch version when merged release Create a release when this pr is merged
Projects
Dashboards
Status: 🔍 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Variables: Uppercase variable formatter
5 participants
@hoobtron @CLAassistant @axelavargas @robhamnett @bfmatei