SceneQueryRunner: allow extra queries and processors to be rerun separately #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd2k
force-pushed
the
query-runner-handle-reprocessing
branch
from
68e4c4c to
21392f6
Compare
sd2k
force-pushed
the
query-runner-handle-reprocessing
branch
2 times, most recently
from
49363a6 to
41672d3
Compare
sd2k
changed the title
sd2k
force-pushed
the
query-runner-handle-reprocessing
branch
4 times, most recently
from
4e1f6cc to
edd16a9
Compare
…rately Followup from [this comment](#587 (comment)) - this adds the option for ExtraQueryProviders to state that they only wish to have their processor rerun (probably with different state), rather than the QueryRunner rerunning both the query _and_ the processor. This is really useful for some ML-based providers which need to run an extra query then transform the results, and also include interactivity such as a slider, but _don't_ need to rerun the query as part of the interactivity - just the processing. There are some downsides here, most notably the extra complexity: - the `ExtraQueryProvider` interface is more flexible but more complex - the `SceneQueryRunner` needs another subscription and `ReplaySubject` in order to be able to re-send the latest unprocessed data to the processors again - I think this will also increase memory usage? Perhaps there's a way to do this using transformations instead?
sd2k
force-pushed
the
query-runner-handle-reprocessing
branch
from
edd16a9 to
c62b35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from this comment
only wish to have their processor rerun (probably with different state),
rather than the QueryRunner rerunning both the query and the processor.
This is really useful for some ML-based providers which need to run an
extra query then transform the results, and also include interactivity
such as a slider, but don't need to rerun the query as part of the
interactivity - just the processing.
There are some downsides here, most notably the extra complexity:
ExtraQueryProviderinterface is more flexible but more complexSceneQueryRunnerneeds another subscription andReplaySubjectin order to be able to re-send the latestunprocessed data to the processors again
Perhaps there's a way for me to do this using transformations instead? That might be preferable. I thought I'd submit this to get feedback though, since it's one solution.