-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VizPanel: support collapsible props #808
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gtk-grafana
added
release
Create a release when this pr is merged
minor
Increment the minor version when merged
no-changelog
labels
Dec 4, 2024
gtk-grafana
changed the title
Allow passthru of panelchrome props
VizPanel: allow any PanelChrome props
Dec 4, 2024
torkelo
reviewed
Dec 4, 2024
gtk-grafana
changed the title
VizPanel: allow any PanelChrome props
VizPanel: support collapsible props
Dec 4, 2024
torkelo
reviewed
Dec 5, 2024
gtk-grafana
added a commit
to grafana/explore-logs
that referenced
this pull request
Dec 5, 2024
torkelo
reviewed
Dec 5, 2024
Comment on lines
87
to
88
collapsible?: PanelChromeProps['collapsible'] | ||
collapsed?: PanelChromeProps['collapsed'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just stick with simple boolean types here, this just obfuscates the simple types that these props really have.
torkelo
approved these changes
Dec 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
minor
Increment the minor version when merged
no-changelog
release
Create a release when this pr is merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support to panel builders to allow passing PanelChrome collapsible props.
e.g.
collapsible
,collapsed
,onToggleCollapse
Example usage:
Notes:
📦 Published PR as canary version:
5.29.0--canary.808.12181324273.0
✨ Test out this PR locally via: