VizPanel: Harden plugin change handling #902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanortegaalba
approved these changes
Sep 16, 2024
torkelo
commented
Sep 16, 2024
| @@ -120,12 +120,17 @@ export class VizPanel<TOptions = {}, TFieldConfig extends {} = {}> extends Scene | |||
| } | |||
|
|
|||
| private _onActivate() { | |||
| if (!this._plugin) { | |||
| if (!this._plugin || this.state.pluginId !== this._plugin.meta.id) { | |||
There was a problem hiding this comment.
@ivanortegaalba this code did not check if the plugin id had changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not needed for grafana/grafana#93045 as I was able to work around it.
But felt that VizPanel should handle pluginId changes a bit better, so making this change for that reason.