Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supply fixed now to datemath caluclations #981

Merged
merged 9 commits into from
Dec 13, 2024
Merged

Supply fixed now to datemath caluclations #981

merged 9 commits into from
Dec 13, 2024

Conversation

oscarkilhed
Copy link
Contributor

evaluateTimeRange uses dateMath.parse that is not deterministic. Sometimes the clock tics over to the next millisecond between calculating to and from. This makes the timerange now-24 to now be 86400001ms instead of 86400000ms (24 hours and one millisecond)

Requires grafana/grafana#97151

@oscarkilhed oscarkilhed mentioned this pull request Nov 28, 2024
Merged
@oscarkilhed
Copy link
Contributor Author

Hmm. Can't really merge this until there is a new version of grafana.data released, unfortunately this was not included in 11.4 released just a few days ago.

torkelo
torkelo reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@torkelo torkelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just import it with a tsignore , but you need a fall back to use the date math.parse if the scenes lib is used in a older version of Grafana that does not have this function

This was referenced Dec 13, 2024
Merged
Merged
@oscarkilhed oscarkilhed added release Create a release when this pr is merged minor Increment the minor version when merged labels Dec 13, 2024
@oscarkilhed oscarkilhed merged commit 2342ba4 into main Dec 13, 2024
5 checks passed
@oscarkilhed oscarkilhed deleted the oscark/supply-fixed-now-to-datemath-calculations branch December 13, 2024 09:09
@scenes-repo-bot-access-token
Copy link

🚀 PR was released in v5.32.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo left review comments

@Sergej-Vlasov Sergej-Vlasov Sergej-Vlasov approved these changes

@ivanortegaalba ivanortegaalba ivanortegaalba approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged release Create a release when this pr is merged released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oscarkilhed @torkelo @ivanortegaalba @Sergej-Vlasov