AdHocFiltersCombobox: Disable "pre-fill filter combobox value on edit" by default #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
added
release
gtk-grafana
requested review from
ashharrison90,
Sergej-Vlasov and
torkelo
and removed request for
ashharrison90
|
@gtk-grafana this was a request from one of the customers. Sorry it was not well thought out by me and experience should have been better. I am trying to address your concerns in this pr #992 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address UX regression introduced by #955.
Since I don't understand what value #955 brings to variables without regex operators or other variables that return results from
getTagValuesProvider, I'm proposing we disable this behavior by default, and developers can set thepopulateInputOnEditon variables where this behavior is desired.Fixes: #986
This PR solves the short-term problem of #955 being forced on all users of the combobox by default.
As a follow-up it would be good to have some documentation added around what #955 is accomplishing, I assume that this is so users can more easily edit regex values, or other variables that don't return results from
getTagValuesProvider. From there we might be able to come up with a better long-term solution (only drop into "edit" mode when there are no values returned bygetTagValuesProvider, or only drop into edit mode when certain operators are selected, differentiate between edit and select a new value etc)