fix(kubernetes-client): Match context & cluster names exactly #948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #947
Looks like the context and cluster names are not yet matched exactly within the ContextFromName function (and the cluster name is not matched exactly in other places). This PR changes that.
This only leads to mis-matches if there are name candidates where the expected name is a suffix of others and at least one of these is lexically sorted before the expected name:
vs.
I'm not sure if the endpoint in
IPFromContext
should also be matched exactly and so I didn't touch that one yet 🙂