-
Notifications
You must be signed in to change notification settings - Fork 34
Service monitor scrap tempo metrics for monolithic #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f7da411
to
9da399b
Compare
840eb9e
to
cd9e42e
Compare
Signed-off-by: Ruben Vargas <[email protected]>
cd9e42e
to
171ae5a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 57.64% 56.01% -1.64%
==========================================
Files 121 125 +4
Lines 11277 11709 +432
==========================================
+ Hits 6501 6559 +58
- Misses 4418 4800 +382
+ Partials 358 350 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
config.Server.HttpServerWriteTimeout = opts.Tempo.Spec.Timeout.Duration | ||
if tempo.Spec.Multitenancy.IsGatewayEnabled() { | ||
// We need this to scrap metrics. | ||
config.Server.HTTPListenAddress = "0.0.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the internal server serve metrics, or only the readiness probes?
internal_server:
http_listen_address: ""
Otherwise everyone has access to the Tempo API and can circumvent the gateway. That means we have to setup mTLS between tempo and the gateway also for the monolithic, which is what I tried to avoid by using localhost
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately internal server doesn't expose the metrics :( We will need to protect it using mTLS which is something I also don't wanted
Signed-off-by: Ruben Vargas <[email protected]>
} | ||
|
||
// SetupWithManager sets up the controller with the Manager. | ||
func (r *CertRotationMonolithicReconciler) SetupWithManager(mgr ctrl.Manager) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this function being called?
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Co-authored-by: Andreas Gerstmayr <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
Signed-off-by: Ruben Vargas <[email protected]>
No description provided.