Skip to content

Commit

Permalink
Merge pull request #101 from grafana/inkel/upgrade-go-ci-checks
Browse files Browse the repository at this point in the history
  • Loading branch information
inkel authored Nov 19, 2024
2 parents a251b71 + c6e2782 commit 2a2b800
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.22

- name: Test
run: make test
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v3
with:
go-version: 1.21
go-version: 1.22

- name: Checks
run: make checks
2 changes: 1 addition & 1 deletion cmd/unused-exporter/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func runWebServer(ctx context.Context, cfg config) error {
})
mux.HandleFunc("/", func(w http.ResponseWriter, req *http.Request) {
if req.URL.Path == "/" {
fmt.Fprintf(w, indexTemplate, cfg.Web.Path)
fmt.Fprintf(w, indexTemplate, cfg.Web.Path) // nolint:errcheck
} else {
http.NotFound(w, req)
}
Expand Down
4 changes: 2 additions & 2 deletions cmd/unused/internal/ui/group_table.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func GroupTable(ctx context.Context, options Options) error {
totalSize := make(map[groupKey]int)
totalCount := make(map[groupKey]int)

fmt.Fprintln(w, strings.Join(headers, "\t"))
fmt.Fprintln(w, strings.Join(headers, "\t")) // nolint:errcheck

var aggrValue string
for _, d := range disks {
Expand Down Expand Up @@ -79,7 +79,7 @@ func GroupTable(ctx context.Context, options Options) error {
for _, aggrKey := range keys {
row := aggrKey[:]
row = append(row, strconv.Itoa(totalCount[aggrKey]), strconv.Itoa(totalSize[aggrKey]))
fmt.Fprintln(w, strings.Join(row, "\t"))
fmt.Fprintln(w, strings.Join(row, "\t")) // nolint:errcheck
}

if err := w.Flush(); err != nil {
Expand Down
4 changes: 2 additions & 2 deletions cmd/unused/internal/ui/table.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func Table(ctx context.Context, options Options) error {
headers = append(headers, "PROVIDER_META", "DISK_META")
}

fmt.Fprintln(w, strings.Join(headers, "\t"))
fmt.Fprintln(w, strings.Join(headers, "\t")) // nolint:errcheck

for _, d := range disks {
p := d.Provider()
Expand All @@ -57,7 +57,7 @@ func Table(ctx context.Context, options Options) error {
row = append(row, p.Meta().String(), d.Meta().String())
}

fmt.Fprintln(w, strings.Join(row, "\t"))
fmt.Fprintln(w, strings.Join(row, "\t")) // nolint:errcheck
}

if err := w.Flush(); err != nil {
Expand Down

0 comments on commit 2a2b800

Please sign in to comment.