Add cache to exporter #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inkel
force-pushed
the
inkel/exporter/cache
branch
2 times, most recently
from
d9ca594 to
ad7bd5d
Compare
These will be used to cache the results of polling each provider for unused disks, making the *exporter.Collect method faster and less prone to timeouts.
inkel
force-pushed
the
inkel/exporter/cache
branch
from
806acbd to
e50e891
Compare
…g interface cleaner
Updating Cache: QoL Improvments
|
This probably needs a bit more of work, but I'll work on them while your PR(s) get merged, @logyball 😸 |
This should make the code more readable.
The previous code was using defer, which would release the context.WithTimeout when the program ends, not on each iteration, thus causing deferred functions to pile up, consuming unnecessary memory.
This makes the code more readable.
Co-authored-by: Leandro López <[email protected]>
removing binary accidentally committed
Logyball/cache updates followup / Verbose logging flag
merged :D |
logyball
approved these changes
Dec 4, 2023
rooneyshuman
approved these changes
Dec 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a cache system to the exporter to prevent timeouts when calling
*exporter.Collect. Each given provider will poll in its own goroutine and write the results to the cache; then in the*exporter.Collectmethod we read the values from the cache.