Hackathon Improvements, Dec 2023 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `inkel/logfmt` with `slog`
Signed-off-by: Logan Ballard <[email protected]> updating readme updating to a single loop adding size to labels for logging updating metric name based on CR Update cmd/unused-exporter/exporter.go Co-authored-by: Leandro López <[email protected]> updating readme updating readme
Creating rudimentary size tracking of unused disks
These will be used to cache the results of polling each provider for unused disks, making the *exporter.Collect method faster and less prone to timeouts.
…g interface cleaner
Updating Cache: QoL Improvments
This should make the code more readable.
The previous code was using defer, which would release the context.WithTimeout when the program ends, not on each iteration, thus causing deferred functions to pile up, consuming unnecessary memory.
This makes the code more readable.
Co-authored-by: Leandro López <[email protected]>
removing binary accidentally committed
Logyball/cache updates followup / Verbose logging flag
Add cache to exporter
Add golangci-lint
Add additional logging lines
…tion Collect duration in ms
…s-to-auth Adding Azure Environment var authentication
Conditionally set ns based on provider
inkel
reviewed
Dec 11, 2023
inkel
previously approved these changes
Mar 11, 2024
Update tests job name to build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large-scale changes for
unused-exporter! Outcome of the December 2023 Grafana hackathon team: Garbage Pail Kids aka Los BasuritosWhat
A more comprehensive
unused-exporter. Adding atotal_sizemetric as well as dramatically improving polling performance using caching.Why
Because it's fun! Also so that we could make this something that actually runs as a service.
Major Changes
Minor Changes
slogFollow-ups