Update the metric names to match Prometheus conventions #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found a few improvements to the metrics based on https://prometheus.io/docs/practices/naming/ These are good recommendations in general, and having standard units makes it easier to use the metrics in queries. For example, having everything in bytes, means you can just divide one metric by another without conversion. Having the timestamp in seconds allows easy use with the `time()` function. Signed-off-by: Goutham <[email protected]>
inkel
requested review from
logyball and
paulajulve
and removed request for
logyball
inkel
approved these changes
May 6, 2024
| | `unused_disks_last_used_at` | Last timestamp (unix ms) when this disk was used. GCP only! | | ||
| | `unused_provider_duration_ms` | How long in milliseconds took to fetch this provider information | | ||
| | `unused_disks_last_used_timestamp_seconds` | Last timestamp (unix seconds) when this disk was used. GCP only! | | ||
| | `unused_provider_duration_seconds` | How long in milliseconds took to fetch this provider information | |
There was a problem hiding this comment.
Here the unit is seconds but the description says milliseconds, we should fix this.
paulajulve
reviewed
May 27, 2024
| | `unused_provider_info` | CSP information | | ||
| | `unused_provider_success` | Static metric indicating if collecting the metrics succeeded or not | | ||
|
|
||
| All metrics have the `provider` and `provider_id` labels to identify to which provider instance they belong. | ||
| The `unused_disks_count` and `unused_disks_size_gb` metrics have an additional `k8s_namespace` metric mapped to the `kubernetes.io/created-for/pvc/namespace` annotation assigned to persistent disks created by Kubernetes. | ||
| The `unused_disks_count` and `unused_disks_total_size_bytes` metrics have an additional `k8s_namespace` metric mapped to the `kubernetes.io/created-for/pvc/namespace` annotation assigned to persistent disks created by Kubernetes. |
There was a problem hiding this comment.
Oops, I didn't see this line when I added unused_disk_size_bytes and it has this label too. Not a blocker in any way, but would you mind adding it here to the list? Thanks a lot! ❤️
logyball
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a few improvements to the metrics based on https://prometheus.io/docs/practices/naming/
These are good recommendations in general, and having standard units makes it easier to use the metrics in queries.
For example, having everything in bytes, means you can just divide one metric by another without conversion.
Having the timestamp in seconds allows easy use with the
time()function.