Replace individual inputs with JSON string array of inputs #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
force-pushed
the
jdb/deploy-preview
branch
from
7507df0 to
e90777a
Compare
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
|
💻 Deploy preview available: |
Signed-off-by: Jack Baldry <[email protected]>
4 tasks
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
jdbaldry
requested review from
chri2547,
clayton-cornell,
knylander-grafana and
a team
as code owners
robbymilo
reviewed
Feb 5, 2025
This requires the same branch name for builds across multiple repositories but that's not too painful and isn't yet a planned use case. Signed-off-by: Jack Baldry <[email protected]>
robbymilo
reviewed
Feb 7, 2025
| @@ -204,16 +227,26 @@ jobs: | |||
| with: | |||
| name: deploy_preview | |||
| status: "${{ job.status }}" | |||
| url: "${{ steps.deploy.outputs.url }}${{ inputs.relative_prefix }}" | |||
| url: "${{ steps.deploy.outputs.url }}${{ (fromJSON(inputs.sources))[0].relative_prefix }}" | |||
There was a problem hiding this comment.
I think only a single URL here is fine but it might cause some confusion.
There was a problem hiding this comment.
Yeah I meant to check if I can put multiple URLs into the status check but I don't think I can
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us build multiples sources in a single deploy preview as demonstrated in grafana/mimir#10580.
I also think it allows us to mount source projects into Grafana Cloud documentation directly instead of a publishing directory although it doesn't use Hugo mounts for that.
Let me know if you'd like me to test anything specifically out for you so you can be confident in the changes.
This can be rolled out safely as tested in:
Signed-off-by: Jack Baldry [email protected]