Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k6/x/sm JavaScript module registration disabled due to #30 #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szkiba
Copy link

@szkiba szkiba commented Dec 18, 2024

The k6/x/sm JavaScript module registration disabled due to #30

@szkiba szkiba requested a review from a team as a code owner December 18, 2024 14:32
@szkiba szkiba linked an issue Dec 18, 2024 that may be closed by this pull request
@nadiamoe
Copy link
Member

Hey Ivan, thanks for your PR.

This k6/x/sm JavaScript module is apparently an experimental development

This is definitely not the case, Synthetic monitoring runs this extension in production tens of times per second to run scripted checks.

Regarding the changes in the PR, I'm not sure what are the effects of commenting those lines. Does the extension still function as an output by doing that? (I suspect yes, as the integration test passed on this PR, but would be good to confirm).

@szkiba
Copy link
Author

szkiba commented Dec 19, 2024

Hey Nadia,

This k6/x/sm JavaScript module is apparently an experimental development

This is definitely not the case, Synthetic monitoring runs this extension in production tens of times per second to run scripted checks.

I wrote about the JavaScript module as experimental. xk6-sm is primarily an output extension and is used as such.

Regarding the changes in the PR, I'm not sure what are the effects of commenting those lines. Does the extension still function as an output by doing that? (I suspect yes, as the integration test passed on this PR, but would be good to confirm).

Of course it will continue to work as an output extension. The two registrations (JavaScript and Output) are independent of each other.

BTW If you look at the probe.go file you will see that it is an experiment (metric named foo_bar, debug messages etc).

@nadiamoe
Copy link
Member

Ah, I see what you mean now. I don't think anything in the probe.go file is used or meant to be used in the short term, so we might just delete the file as well.

I have some work to do on this repo in the short term which will refactor how we handle metrics, but after that, I can take care of removing this for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "k6/x/sm" JavaScript module should not be registered
2 participants