Prevented full screen swipe pop gesture conflict #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only way to opt into the default pop behavior is by not implementing animationControllerForOperation - as soon as implement it then never get the built-in pop gesture support. If don't get the built-in then can't get the ios26 full screen gesture properly - where it doesn't conflict with horizontal scroll view, for example. Tried returning NO/YES from various gesture recognizer stuff but can never get the non-conflict. Plan to move the delegate off the NavigationStackView into separate classes. Then can add the right delegate depending on whether want custom animation or not. 99% of times there's no custom animation so add delegate without animationControllerForOperation and get default pop gestures
Created controller delegate that calls back to the view to handle. This allows registering different delegates for custom animations - so the 99% case doesn't implement animationControllerForOperation and so get the default ios gestures for popping
Swapped in the transition delegate and added custom animations and it works
Only want the delegate with animationControllerForOperation if custom animation otherwise can't fallback to default ios pop gestures - and end up with conflict with horizontal scroll. So added basic controller delegate if custom animation false and the transition one otherwise. Also only added the custom gesture recognizer if custom animation, too - the swipe from edge and full swipe - don't need them if not custom because ios handles it. And ios prevents the gesture conflict too - that's whole point of this work
Then only swap if changed in updateProps - does mean the default is setup pointlessly if custom animation on but that doesn't matter.
On Tweets made FlatList horizontal and changed from custom to none then couldn't swipe back from edge. When delegate set to nil then works for vertical scroll but not horizontal. Fixed by restoring the actual gesture recognizer delegate set by ios instead of setting to nil
No idea why, but on the old arch setting to nil didn't allow swipe back from edge on horizontal list. On the new arch, can swipe back. Think it's better to restore the original delegate used by ios than to set to nil anyway
Implemented the new custom animation property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swiping to scroll a horizontal list incorrectly triggered the full screen pop gesture. This conflict happened because the Navigation router was deciding when to begin the gesture instead of leaving it up to iOS. Tried various things to prevent the conflict but no luck (even the gesture experts at software mansion struggling with it). Ideally want the default pop gesture handling built into iOS. But implementing
animationControllerForOperationinUINavigationControllerDelegatestops iOS from running its default pop gestures - even when returning nil.First implemented
animationControllerForOperationwhen introducing custom animations in #778. But custom animations in iOS are very rare and they don't even work that well in iOS 26 because iOS waits for them to complete before starting the next one (unlike the default animations), making them feel dated.Changed to only implement
animationControllerForOperationwhen custom animations are on. Created 2UINavigationControllerDelegates- one withoutanimationControllerForOperationand one with. Then choose which one to use based on thecustomAnimationsprop. That way, 99% of the time (custom animations off) iOS handles the pop gestures and prevents the conflict with horizontal lists, for example.