Fix FUNC_GPIO0_CLK_OUT1 issue #1188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts
FUNC_GPIO0_CLK_OUT1(soc/esp32/register/soc/io_mux_reg.h) behind a flag: Without this change faust2esp32 output can only be compiled forESP32target chip (the name is confusing so just to be clear, this is not referring to the family but the original ESP32). For example, my targetESP32S3doesn't compile because this define doesn't exist in soc/esp32s3/register/soc/io_mux_reg.h. Maybe this could be configurable but I don't believe it's strictly necessary.Extracted from #1187